From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
stable@kernel.org
Subject: Re: [PATCH v2 4/6] arm64: dts: renesas: r9a07g044: Update overfow/underflow IRQ names for MTU3 channels
Date: Tue, 25 Jul 2023 11:00:46 +0200 [thread overview]
Message-ID: <CAMuHMdUoPugUVtPwrPEvKXjOOU-Bq=-tDbCtFFT3Ryh6B8O+pg@mail.gmail.com> (raw)
In-Reply-To: <20230724091927.123847-5-biju.das.jz@bp.renesas.com>
Hi Biju,
On Mon, Jul 24, 2023 at 11:19 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> As per R01UH0914EJ0130 Rev.1.30 HW manual the MTU3 overflow/underflow
> interrupt names starts with 'tci' instead of 'tgi'.
>
> Replace the below overflow/underflow interrupt names:
> - tgiv0->tciv0
> - tgiv1->tciv1
> - tgiu1->tciu1
> - tgiv2->tciv2
> - tgiu2->tciu2
> - tgiv3->tciv3
> - tgiv4->tciv4
> - tgiv6->tciv6
> - tgiv7->tciv7
> - tgiv8->tciv8
> - tgiu8->tciu8
>
> Fixes: 26336d66d021 ("arm64: dts: renesas: r9a07g044: Add MTU3a node")
> Fixes: dd123dd01def ("arm64: dts: renesas: r9a07g054: Add MTU3a node")
These were added in v6.5-rc1, so it would be good to get this fixed before
the final release of v6.5 (i.e. before I sent my first PR for v6.6
later this week).
> Cc: stable@kernel.org
No need to CC stable.
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v1->v2:
> * No change.
Thanks for your patch!
> ---
> arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 16 ++++++++--------
> arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 16 ++++++++--------
> 2 files changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> index 232910e07444..66f68fc2b241 100644
> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> @@ -223,20 +223,20 @@ mtu3: timer@10001200 {
> <GIC_SPI 212 IRQ_TYPE_EDGE_RISING>,
> <GIC_SPI 213 IRQ_TYPE_EDGE_RISING>;
> interrupt-names = "tgia0", "tgib0", "tgic0", "tgid0",
> - "tgiv0", "tgie0", "tgif0",
> - "tgia1", "tgib1", "tgiv1", "tgiu1",
> - "tgia2", "tgib2", "tgiv2", "tgiu2",
> + "tciv0", "tgie0", "tgif0",
> + "tgia1", "tgib1", "tciv1", "tciu1",
> + "tgia2", "tgib2", "tciv2", "tciu2",
> "tgia3", "tgib3", "tgic3", "tgid3",
> - "tgiv3",
> + "tciv3",
> "tgia4", "tgib4", "tgic4", "tgid4",
> - "tgiv4",
> + "tciv4",
> "tgiu5", "tgiv5", "tgiw5",
> "tgia6", "tgib6", "tgic6", "tgid6",
> - "tgiv6",
> + "tciv6",
> "tgia7", "tgib7", "tgic7", "tgid7",
> - "tgiv7",
> + "tciv7",
> "tgia8", "tgib8", "tgic8", "tgid8",
> - "tgiv8", "tgiu8";
> + "tciv8", "tciu8";
> clocks = <&cpg CPG_MOD R9A07G044_MTU_X_MCK_MTU3>;
> power-domains = <&cpg>;
> resets = <&cpg R9A07G044_MTU_X_PRESET_MTU3>;
While SPI 213 is documented to be used for TCIU8, the actual MTU3a
documentation does not mention this interrupt.
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-07-25 9:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 9:19 [PATCH v2 0/6] Add RZ/G2UL MTU3a support Biju Das
2023-07-24 9:19 ` [PATCH v2 1/6] dt-bindings: timer: renesas,rz-mtu3: Improve documentation Biju Das
2023-07-24 15:15 ` Geert Uytterhoeven
2023-07-24 15:24 ` Biju Das
2023-07-24 9:19 ` [PATCH v2 2/6] dt-bindings: timer: renesas,rz-mtu3: Fix overflow/underflow interrupt names Biju Das
2023-07-25 8:52 ` Geert Uytterhoeven
2023-07-25 9:11 ` Biju Das
2023-07-25 9:32 ` Geert Uytterhoeven
2023-07-25 9:49 ` Biju Das
2023-07-24 9:19 ` [PATCH v2 3/6] dt-bindings: timer: renesas,rz-mtu3: Document RZ/G2UL SoC Biju Das
2023-07-24 15:26 ` Geert Uytterhoeven
2023-07-24 15:29 ` Biju Das
2023-07-24 9:19 ` [PATCH v2 4/6] arm64: dts: renesas: r9a07g044: Update overfow/underflow IRQ names for MTU3 channels Biju Das
2023-07-25 9:00 ` Geert Uytterhoeven [this message]
2023-07-25 9:14 ` Biju Das
2023-07-25 9:33 ` Geert Uytterhoeven
2023-07-24 9:19 ` [PATCH v2 5/6] arm64: dts: renesas: r9a07g043: Add MTU3a node Biju Das
2023-07-24 9:19 ` [PATCH v2 6/6] arm64: dts: renesas: rzg2ul-smarc: Add support for enabling MTU3 Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUoPugUVtPwrPEvKXjOOU-Bq=-tDbCtFFT3Ryh6B8O+pg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.