From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] gpio: gpiolib: remove shadowed variable
Date: Mon, 1 Feb 2021 10:04:00 +0100 [thread overview]
Message-ID: <CAMuHMdVYjrs4R+s=ojBegn1PczZ8fiD+95od5Nj9wG02+6TBcA@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJWKEHsdHAnQt-ozVPHDcjSPrTo3c7D8gGFiPvwrA8TzwQ@mail.gmail.com>
Hi Bartosz,
On Mon, Feb 1, 2021 at 9:59 AM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> On Wed, Jan 27, 2021 at 11:39 AM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > On Tue, Jan 05, 2021 at 12:14:34PM +0100, Geert Uytterhoeven wrote:
> > > On Tue, Jan 5, 2021 at 12:00 PM Wolfram Sang
> > > <wsa+renesas@sang-engineering.com> wrote:
> > > > After refactoring, we had two variables for the same thing. Remove the
> > > > second declaration, one is enough here. Found by cppcheck.
> > > >
> > > > drivers/gpio/gpiolib.c:2551:17: warning: Local variable 'ret' shadows outer variable [shadowVariable]
> > > >
> > > > Fixes: d377f56f34f5 ("gpio: gpiolib: Normalize return code variable name")
> > > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Ccing Linus & Bartosz
> >
>
> For some reason this is not on patchwork and I also don't have it in
> my inbox, can you resend, please?
https://lore.kernel.org/linux-gpio/20210105105914.13172-1-wsa+renesas@sang-engineering.com/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-02-01 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 10:59 [PATCH] gpio: gpiolib: remove shadowed variable Wolfram Sang
2021-01-05 11:14 ` Geert Uytterhoeven
2021-01-27 10:39 ` Wolfram Sang
2021-02-01 8:58 ` Bartosz Golaszewski
2021-02-01 9:04 ` Geert Uytterhoeven [this message]
2021-02-01 12:25 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVYjrs4R+s=ojBegn1PczZ8fiD+95od5Nj9wG02+6TBcA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.