Re: [PATCH 1/2] arm64: dts: renesas: r8a779g0: R-Car Ethernet TSN support

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: renesas: r8a779g0: R-Car Ethernet TSN support
Date: Thu, 15 Feb 2024 17:11:18 +0100	[thread overview]
Message-ID: <CAMuHMdV_a2u7PPaYbu+zU7-5jN2+ux6e4AAsWxC6+LCFyfvgPQ@mail.gmail.com> (raw)
In-Reply-To: <20240122160441.759620-2-niklas.soderlund+renesas@ragnatech.se>

Hi Niklas,

On Mon, Jan 22, 2024 at 5:06 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Add Ethernet TSN support for R-Car V4H.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> @@ -538,6 +538,22 @@ tmu4: timer@ffc00000 {
>                         status = "disabled";
>                 };
>
> +               tsn0: ethernet@e6460000 {
> +                       compatible = "renesas,r8a779g0-ethertsn", "renesas,rcar-gen4-ethertsn";
> +                       reg = <0 0xe6460000 0 0x7000>,
> +                             <0 0xe6449000 0 0x500>;
> +                       reg-names = "tsnes", "gptp";
> +                       interrupts = <GIC_SPI 429 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 430 IRQ_TYPE_LEVEL_HIGH>;
> +                       interrupt-names = "tx", "rx";
> +                       clocks = <&cpg CPG_MOD 2723>;
> +                       power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +                       resets = <&cpg 2723>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +                       status = "disabled";
> +               };
> +
>                 i2c0: i2c@e6500000 {
>                         compatible = "renesas,i2c-r8a779g0",
>                                      "renesas,rcar-gen4-i2c";

Matches the bindings (for which I did have some comments), so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds