From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x
Date: Thu, 4 Mar 2021 09:42:44 +0100 [thread overview]
Message-ID: <CAMuHMdVgasQPwQRsoi3nc6jqBaL7yhwBoyo7feac=f7dLnz5Uw@mail.gmail.com> (raw)
In-Reply-To: <a92afef3-2ae8-e8c7-855d-f0e86a1beede@omprussia.ru>
On Sun, Feb 28, 2021 at 9:54 PM Sergey Shtylyov <s.shtylyov@omprussia.ru> wrote:
> According to the SH7710, SH7712, SH7713 Group User's Manual: Hardware,
> Rev. 3.00, the TRSCER register actually has only bit 7 valid (and named
> differently), with all the other bits reserved. Apparently, this was not
> the case with some early revisions of the manual as we have the other
> bits declared (and set) in the original driver. Follow the suit and add
> the explicit sh_eth_cpu_data::trscer_err_mask initializer for SH771x...
>
> Fixes: 86a74ff21a7a ("net: sh_eth: add support for Renesas SuperH Ethernet")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-03-04 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 20:24 [PATCH net 0/3] Fix TRSCER masks in the Ether driver Sergey Shtylyov
2021-02-28 20:25 ` [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x Sergey Shtylyov
2021-03-04 8:42 ` Geert Uytterhoeven [this message]
2021-02-28 20:26 ` [PATCH net 2/3] sh_eth: fix TRSCER mask for R7S72100 Sergey Shtylyov
2021-03-04 8:44 ` Geert Uytterhoeven
2021-02-28 20:27 ` [PATCH net 3/3] sh_eth: fix TRSCER mask for R7S9210 Sergey Shtylyov
2021-03-04 8:51 ` Geert Uytterhoeven
2021-03-01 21:30 ` [PATCH net 0/3] Fix TRSCER masks in the Ether driver patchwork-bot+netdevbpf
2021-03-02 16:32 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVgasQPwQRsoi3nc6jqBaL7yhwBoyo7feac=f7dLnz5Uw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.shtylyov@omprussia.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.