Re: [PATCH v2] dt-bindings: serial: renesas,scif: Document R9A09G057 support

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Magnus Damm <magnus.damm@gmail.com>,
	linux-kernel@vger.kernel.org,  linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org,  linux-renesas-soc@vger.kernel.org,
	 Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	 Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v2] dt-bindings: serial: renesas,scif: Document R9A09G057 support
Date: Thu, 7 Mar 2024 14:35:14 +0100	[thread overview]
Message-ID: <CAMuHMdVi7ageQMmZYqCZJnCX79SBW=FGEHTMv7fZWRGmw4WwJg@mail.gmail.com> (raw)
In-Reply-To: <20240307114731.34953-1-prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi Prabhakar,

On Thu, Mar 7, 2024 at 12:48 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Document support for the Serial Communication Interface with FIFO (SCIF)
> available in the Renesas RZ/V2H(P) (R9A09G057) SoC. The SCIF interface in
> the Renesas RZ/V2H(P) is similar to that available in the RZ/G2L
> (R9A07G044) SoC, with the only difference being that the RZ/V2H(P) SoC has
> three additional interrupts: one for Tx end/Rx ready and the other two for
> Rx and Tx buffer full, which are edge-triggered.
>
> No driver changes are required as generic compatible string
> "renesas,scif-r9a07g044" will be used as a fallback on RZ/V2H(P) SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
> v1->v2
> * Added validation to check interrupts and interrupt-names count

Thanks for the update!

> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> @@ -77,6 +77,7 @@ properties:
>                - renesas,scif-r9a07g043      # RZ/G2UL and RZ/Five
>                - renesas,scif-r9a07g054      # RZ/V2L
>                - renesas,scif-r9a08g045      # RZ/G3S
> +              - renesas,scif-r9a09g057      # RZ/V2H(P)
>            - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback
>
>    reg:
> @@ -91,6 +92,9 @@ properties:
>        - description: Break interrupt
>        - description: Data Ready interrupt
>        - description: Transmit End interrupt
> +      - description: Transmit End/Data Ready interrupt
> +      - description: Receive buffer full interrupt (EDGE trigger)
> +      - description: Transmit buffer empty interrupt (EDGE trigger)
>
>    interrupt-names:
>      minItems: 4
> @@ -101,6 +105,9 @@ properties:
>        - const: bri
>        - const: dri
>        - const: tei
> +      - const: teidri

As the documentation calls this interrupt "ub1_tei_dri_n", I think
"tei-dri" would be a better name.

> +      - const: rxi-edge
> +      - const: txi-edge

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds