From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: sh-msiof: avoid integer overflow in constants
Date: Tue, 30 Jan 2024 15:09:29 +0100 [thread overview]
Message-ID: <CAMuHMdWYZ99dm4DmKD25qu2uGXaoxYbqsq0A_K2sz=OB=nXgxg@mail.gmail.com> (raw)
In-Reply-To: <Zbj8Qyqu8KQ4Rshp@ninjato>
Hi Wolfram,
On Tue, Jan 30, 2024 at 2:40 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > > But they don't match, so we can't unify them?
> >
> > I stand corrected...
>
> So, the patch is good as-is?
Yeah...
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Still, it might make sense to apply the same change to the
SIFCTR_RFWM_* definitions. However, that would still leave us with
inconsistencies with other bitfield definitions in the file...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2024-01-30 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 9:40 [PATCH] spi: sh-msiof: avoid integer overflow in constants Wolfram Sang
2024-01-30 10:14 ` Geert Uytterhoeven
2024-01-30 11:26 ` Wolfram Sang
2024-01-30 11:39 ` Geert Uytterhoeven
2024-01-30 13:40 ` Wolfram Sang
2024-01-30 14:09 ` Geert Uytterhoeven [this message]
2024-01-30 19:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWYZ99dm4DmKD25qu2uGXaoxYbqsq0A_K2sz=OB=nXgxg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.