All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Magnus <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	LUU HOAI <hoai.luu.ub@renesas.com>,
	Takeshi Kihara <takeshi.kihara.df@renesas.com>,
	Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>,
	Khiem Nguyen <khiem.nguyen.xt@renesas.com>,
	Hien Dang <hien.dang.eb@renesas.com>
Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a77995: add R-Car Sound support
Date: Tue, 25 May 2021 09:40:53 +0200	[thread overview]
Message-ID: <CAMuHMdWsH=eydBaHH99UCUSooB6qptM4tWO71U4e3vTZ9uHWBw@mail.gmail.com> (raw)
In-Reply-To: <87zgwkofex.wl-kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

On Mon, May 24, 2021 at 7:43 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > Please use numerical sort order when adding nodes with unit addresses.
>
> It seems r8a77995.dtsi numerical sort order is already broken.
> Or am I misunderstanding ?
>
>         ...
>         ipmmu_vi0: iommu@febd0000
>         ipmmu_vp0: iommu@fe990000
> =>      avb: ethernet@e6800000
> =>      can0: can@e6c30000
>         ---- and ore ----

We use numerical sort order, but group similar entries together.
I.e. all iommu nodes are together, and their position is determined by
the unit address of the first iommu node.

I really should write a script to automate sorting, and propose that as
the gold standard...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2021-05-25  7:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  0:36 [PATCH 0/3] arm64: dts: renesas: r8a77995: draak: add R-Car Sound support Kuninori Morimoto
2021-05-17  0:36 ` [PATCH 1/3] clk: renesas: r8a77995: Add ZA2 clock Kuninori Morimoto
2021-05-17  9:36   ` Geert Uytterhoeven
2021-05-17 22:20     ` Kuninori Morimoto
2021-05-24  0:57       ` Kuninori Morimoto
2021-05-25  7:42         ` Geert Uytterhoeven
2021-05-17  0:36 ` [PATCH 2/3] arm64: dts: renesas: r8a77995: add R-Car Sound support Kuninori Morimoto
2021-05-17 11:33   ` Geert Uytterhoeven
2021-05-17 22:27     ` Kuninori Morimoto
2021-05-24  5:43       ` Kuninori Morimoto
2021-05-25  7:40         ` Geert Uytterhoeven [this message]
2021-05-25 22:53           ` Kuninori Morimoto
2021-05-17  0:37 ` [PATCH 3/3] arm64: dts: renesas: r8a77995: draak: Add " Kuninori Morimoto
2021-05-17 11:46   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdWsH=eydBaHH99UCUSooB6qptM4tWO71U4e3vTZ9uHWBw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=harunobu.kurokawa.dn@renesas.com \
    --cc=hien.dang.eb@renesas.com \
    --cc=hoai.luu.ub@renesas.com \
    --cc=kazuya.mizuguchi.ks@renesas.com \
    --cc=khiem.nguyen.xt@renesas.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=takeshi.kihara.df@renesas.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.