From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Magnus <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
LUU HOAI <hoai.luu.ub@renesas.com>,
Takeshi Kihara <takeshi.kihara.df@renesas.com>,
Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com>,
Khiem Nguyen <khiem.nguyen.xt@renesas.com>,
Hien Dang <hien.dang.eb@renesas.com>
Subject: Re: [PATCH v3 2/3] arm64: dts: renesas: r8a77995: add R-Car Sound support
Date: Thu, 27 May 2021 11:19:31 +0200 [thread overview]
Message-ID: <CAMuHMdX3OM-7y+LxkQWkTm2ZgUDTP3=ATs48zFP2CSkRU_DwFg@mail.gmail.com> (raw)
In-Reply-To: <87o8cwlrmp.wl-kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
On Thu, May 27, 2021 at 6:36 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> This patch adds R-Car Sound and Audio-DMAC support for D3.
> One note is that D3's SSI0-2 and SRC0-4 are not connected.
>
> Link: https://lore.kernel.org/r/87k0nyci2t.wl-kuninori.morimoto.gx@renesas.com
> Link: https://lore.kernel.org/r/87sg2boi3h.wl-kuninori.morimoto.gx@renesas.com
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -1015,6 +1032,155 @@ vin4: video@e6ef4000 {
> status = "disabled";
> };
>
> + rcar_sound: sound@ec500000 {
> + /*
> + * #sound-dai-cells is required
> + *
> + * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>;
> + * Multi DAI : #sound-dai-cells = <1>; <&rcar_sound N>;
> + */
> + /*
> + * #clock-cells is required for audio_clkout0/1/2/3
> + *
> + * clkout : #clock-cells = <0>; <&rcar_sound>;
> + * clkout0/1/2/3: #clock-cells = <1>; <&rcar_sound N>;
> + */
> + compatible = "renesas,rcar_sound-r8a77995", "renesas,rcar_sound-gen3";
> + reg = <0 0xec500000 0 0x1000>, /* SCU */
> + <0 0xec5a0000 0 0x100>, /* ADG */
> + <0 0xec540000 0 0x1000>, /* SSIU */
> + <0 0xec541000 0 0x280>, /* SSI */
> + <0 0xec740000 0 0x200>; /* Audio DMAC peri peri*/
> + reg-names = "scu", "adg", "ssiu", "ssi", "audmapp";
> +
> + clocks = <&cpg CPG_MOD 1005>,
> + <&cpg CPG_MOD 1011>, <&cpg CPG_MOD 1012>,
> + <&cpg CPG_MOD 1025>, <&cpg CPG_MOD 1026>,
> + <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
> + <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>,
> + <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>,
> + <&audio_clk_a>, <&audio_clk_b>,
> + <&cpg CPG_CORE R8A77995_CLK_ZA2>;
> + clock-names = "ssi-all",
> + "ssi.4", "ssi.3",
> + "src.6", "src.5",
> + "mix.1", "mix.0",
> + "ctu.1", "ctu.0",
> + "dvc.0", "dvc.1",
> + "clk_a", "clk_b", "clk_i";
> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> + resets = <&cpg 1005>,
> + <&cpg 1011>, <&cpg 1012>;
> + reset-names = "ssi-all",
> + "ssi.4", "ssi.3";
> + status = "disabled";
> +
> + rcar_sound,ctu {
> + ctu00: ctu-0 { };
> + ctu01: ctu-1 { };
> + ctu02: ctu-2 { };
> + ctu03: ctu-3 { };
> + ctu10: ctu-4 { };
> + ctu11: ctu-5 { };
> + ctu12: ctu-6 { };
> + ctu13: ctu-7 { };
> + };
> +
> + rcar_sound,dvc {
> + dvc0: dvc-0 {
> + dmas = <&audma0 0xbc>;
> + dma-names = "tx";
> + };
> + dvc1: dvc-1 {
> + dmas = <&audma0 0xbe>;
> + dma-names = "tx";
> + };
> + };
> +
> + rcar_sound,mix {
> + mix0: mix-0 { };
> + mix1: mix-1 { };
> + };
> +
> + rcar_sound,src {
> + src0: src-0 { status = "disabled"; };
> + src1: src-1 { status = "disabled"; };
> + src2: src-2 { status = "disabled"; };
> + src3: src-3 { status = "disabled"; };
> + src4: src-4 { status = "disabled"; };
Please drop nonexistent src channels.
> + src5: src-5 {
> + interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>;
> + dmas = <&audma0 0x8f>, <&audma0 0xb2>;
> + dma-names = "rx", "tx";
> + };
> + src6: src-6 {
> + interrupts = <GIC_SPI 358 IRQ_TYPE_LEVEL_HIGH>;
> + dmas = <&audma0 0x91>, <&audma0 0xb4>;
> + dma-names = "rx", "tx";
> + };
> + };
> +
> + rcar_sound,ssi {
> + ssi0: ssi-0 { status = "disabled"; };
> + ssi1: ssi-1 { status = "disabled"; };
> + ssi2: ssi-2 { status = "disabled"; };
Please drop nonexistent ssi channels.
> + ssi3: ssi-3 {
> + interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>;
> + dmas = <&audma0 0x07>, <&audma0 0x08>,
> + <&audma0 0x6f>, <&audma0 0x70>;
> + dma-names = "rx", "tx", "rxu", "txu";
> + };
> + ssi4: ssi-4 {
> + interrupts = <GIC_SPI 374 IRQ_TYPE_LEVEL_HIGH>;
> + dmas = <&audma0 0x09>, <&audma0 0x0a>,
> + <&audma0 0x71>, <&audma0 0x72>;
> + dma-names = "rx", "tx", "rxu", "txu";
> + };
> + };
> + };
With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-05-27 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 4:36 [PATCH v3 0/3] arm64: dts: renesas: r8a77995: draak: add R-Car Sound support Kuninori Morimoto
2021-05-27 4:36 ` [PATCH v3 1/3] clk: renesas: r8a77995: Add ZA2 clock Kuninori Morimoto
2021-05-27 9:12 ` Geert Uytterhoeven
2021-05-27 4:36 ` [PATCH v3 2/3] arm64: dts: renesas: r8a77995: add R-Car Sound support Kuninori Morimoto
2021-05-27 9:19 ` Geert Uytterhoeven [this message]
2021-05-27 4:36 ` [PATCH v3 3/3] arm64: dts: renesas: r8a77995: draak: Add " Kuninori Morimoto
2021-05-27 9:26 ` Geert Uytterhoeven
2021-06-04 1:33 ` [PATCH v3 0/3] arm64: dts: renesas: r8a77995: draak: add " Kuninori Morimoto
2021-06-04 8:03 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdX3OM-7y+LxkQWkTm2ZgUDTP3=ATs48zFP2CSkRU_DwFg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=harunobu.kurokawa.dn@renesas.com \
--cc=hien.dang.eb@renesas.com \
--cc=hoai.luu.ub@renesas.com \
--cc=kazuya.mizuguchi.ks@renesas.com \
--cc=khiem.nguyen.xt@renesas.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=takeshi.kihara.df@renesas.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.