Re: [PATCH v5 2/2] soc: renesas: Add PWC support for RZ/V2M

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: fabrizio.castro.jz@renesas.com
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sebastian Reichel <sre@kernel.org>, Lee Jones <lee@kernel.org>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das@bp.renesas.com>,
	linux-renesas-soc@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Jacopo Mondi <jacopo@jmondi.org>
Subject: Re: [PATCH v5 2/2] soc: renesas: Add PWC support for RZ/V2M
Date: Mon, 16 Jan 2023 13:58:21 +0100	[thread overview]
Message-ID: <CAMuHMdXAFqMRRyfRsV8-ASzdLS5Fa7dS8UrSc73We+=WuOeDZQ@mail.gmail.com> (raw)
In-Reply-To: <20230106125816.10600-3-fabrizio.castro.jz@renesas.com>

On Fri, Jan 6, 2023 at 1:58 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> The Renesas RZ/V2M External Power Sequence Controller (PWC)
> IP is capable of:
> * external power supply on/off sequence generation
> * on/off signal generation for the LPDDR4 core power supply (LPVDD)
> * key input signals processing
> * general-purpose output pins
>
> Add the corresponding device driver.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
>
> v1: In the first version, I had 1 driver for GPIO handling, and 1 driver
>     for poweroff handling, both based on syscon to share the mapped
>     memory region.
> v2: One more driver added to act as MFD core driver. Dropped syscon, and
>     dropped the OF compatible string for the GPIO and poweroff drivers.
> v3: This new patch merges all the PWC code in 1 new driver.
>     It also takes into account the comments received from Bartosz and Geert.
>     Since this is a new driver, I have dropped all the Reviewed-by tags
>     received on the separated drivers.
> v4: No change.
> v5: No change.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.3.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds