Re: [PATCH v4] arm64: dts: renesas: rz-smarc-common: Use versa3 clk for audio mclk

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Magnus Damm <magnus.damm@gmail.com>,
	 "linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	 "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	 Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v4] arm64: dts: renesas: rz-smarc-common: Use versa3 clk for audio mclk
Date: Thu, 5 Oct 2023 13:55:28 +0200	[thread overview]
Message-ID: <CAMuHMdXEEshPhaJCsmkTCagTcwv813CdaY1h0ORdoYe5RCTUNw@mail.gmail.com> (raw)
In-Reply-To: <OS0PR01MB592246E77539C513C1A7FCD686E5A@OS0PR01MB5922.jpnprd01.prod.outlook.com>

On Thu, Aug 31, 2023 at 7:05 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Subject: Re: [PATCH v4] arm64: dts: renesas: rz-smarc-common: Use versa3
> > clk for audio mclk
> > On Fri, Aug 25, 2023 at 11:05 AM Biju Das <biju.das.jz@bp.renesas.com>
> > wrote:
> > > Currently audio mclk uses a fixed clk of 11.2896MHz (multiple of
> > 44.1kHz).
> > > Replace this fixed clk with the programmable versa3 clk that can
> > > provide the clocking to support both 44.1kHz (with a clock of
> > > 11.2896MHz) and 48kHz (with a clock of 12.2880MHz), based on audio
> > > sampling rate for playback and record.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > > v3->v4:
> > >  * Dropped clock-output-names from dtsi files.
> > >  * Updated example with dropping clock-output-names.
> >
> > Thanks for the update!
> >
> > > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > > @@ -105,6 +105,26 @@ &i2c3 {
> > >
> > >         status = "okay";
> > >
> > > +       versa3: versa3@68 {
> >
> > clock-generator@ (everywhere)
> OK.
>
> >
> > > +               compatible = "renesas,5p35023";
> > > +               reg = <0x68>;
> > > +               #clock-cells = <1>;
> > > +               clocks = <&x1>;
> > > +
> > > +               renesas,settings = [
> > > +                       80 00 11 19 4c 02 23 7f 83 19 08 a9 5f 25 24 bf
> > > +                       00 14 7a e1 00 00 00 00 01 55 59 bb 3f 30 90 b6
> > > +                       80 b0 45 c4 95
> > > +               ];
> > > +
> > > +               assigned-clocks = <&versa3 0>, <&versa3 1>,
> > > +                                 <&versa3 2>, <&versa3 3>,
> > > +                                 <&versa3 4>, <&versa3 5>;
> > > +               assigned-clock-rates = <24000000>, <11289600>,
> > > +                                      <11289600>, <12000000>,
> > > +                                      <25000000>, <12288000>;
> > > +       };
> >
> > Please move this node down, to preserve sort order (by unit-address).
> >
> > Same comments arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> >
> > Unless we're gonna need a new iteration for some other reason (the
> > corresponding fixes for the clock index order are not yet in linux-next), I
> > can fix the above while applying...

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.7, now the driver dependency
is in v6.6-rc4.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds