Re: [PATCH 2/4] arm64: dts: renesas: r8a779g0: whitehawk: Add R-Car Sound support

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 2/4] arm64: dts: renesas: r8a779g0: whitehawk: Add R-Car Sound support
Date: Fri, 10 Mar 2023 14:38:29 +0100	[thread overview]
Message-ID: <CAMuHMdXRaL-44EZ+64Knj_Yy_txNZp9HXUzPg9BmTV16Z3WseQ@mail.gmail.com> (raw)
In-Reply-To: <87o7p5l9t7.wl-kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

On Tue, Mar 7, 2023 at 12:49 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> These adds R-Car Sound support for WhiteHawk board using
> ARD-AUDIO-DA7212 external audio board.
> It is using DT overlay.
>
> Signed-off-by: Linh Phung <linh.phung.jy@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks for your patch!

> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-ard-audio-da7212.dtso

> +&{/} {
> +       sound_card: sound {
> +               compatible = "audio-graph-card";
> +               label = "rcar-sound";
> +
> +               dais = <&rsnd_port0>;   /* DA7212 Audio Codec */
> +       };
> +
> +       tpu_clk: tpu_clk {

Will rename to "tpu-clk" while applying, as underscores are not
recommended in node names.

> +&rcar_sound {
> +       pinctrl-0 = <&sound_clk_pins>, <&sound_pins>;
> +       pinctrl-names = "default";
> +
> +       /* Single DAI */
> +       #sound-dai-cells = <0>;
> +
> +       /* audio_clkout */
> +       #clock-cells = <0>;
> +       clock-frequency = <5644800>; /* 44.1kHz groups [(C) clock] */
> +//     clock-frequency = <6144000>; /* 48  kHz groups [(C) clock] */
> +
> +       status = "okay";
> +
> +       /* update <clkin> to <tpu_clk> */
> +       clocks = <&cpg CPG_MOD 2926>, <&cpg CPG_MOD 2927>, <&tpu_clk>;
> +
> +       ports {
> +               rsnd_port0: port {

Will change to "rsnd_port:", as you dropped the @0.

> +                       rsnd_endpoint: endpoint {
> +                               remote-endpoint = <&da7212_endpoint>;
> +
> +                               dai-format = "i2s";
> +                               bitclock-master = <&rsnd_endpoint>;
> +                               frame-master = <&rsnd_endpoint>;
> +
> +                               /* Please use exclusively to the 'capture' */
> +                               playback = <&ssi0>;
> +                               /* [CAPTURE] */
> +                               /* capture = <&ssi0>; */
> +                       };
> +               };
> +       };
> +};

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.4, with the above fixed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds