Re: [PATCH 5/6] pinctrl: renesas: Add support for R-Car SoCs with pull-down only pins

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Ulrich Hecht <uli+renesas@fpond.eu>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 5/6] pinctrl: renesas: Add support for R-Car SoCs with pull-down only pins
Date: Mon, 22 Mar 2021 16:11:08 +0100	[thread overview]
Message-ID: <CAMuHMdXVeJC74tGrOER+aJpV5q373inQVEK_N1N=4cKQiQgN_g@mail.gmail.com> (raw)
In-Reply-To: <YFiyvr30r6O6qFgH@oden.dyn.berto.se>

Hi Niklas,

On Mon, Mar 22, 2021 at 4:07 PM Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
> On 2021-03-03 14:26:18 +0100, Geert Uytterhoeven wrote:
> > Currently, the common R-Car bias handling supports pin controllers with
> > either:
> >   1. Separate pin Pull-Enable (PUEN) and pin Pull-Up/Down control (PUD)
> >      registers, for controlling both pin pull-up and pin pull-down,
> >   2. A single pin Pull-Up control register (PUPR), for controlling pin
> >      pull-up.
> >
> > Add support for a variant of #2, where some bits in the single pin
>
> s/bits/bit/ ?

I think there can be multiple, in the generic case.

> > Pull-Up control register (PUPR) control pin pull-down instead of pin
> > pull-up.  This is the case for the "ASEBRK#/ACK" pin on R-Car M2-W,
> > M2-N, and E2, and the "ACK" pin on RZ/G1M, RZ/G1N, RZ/G1E, and RZ/G1C.
> > To describe such a register, SoC-specific drivers need to provide two
> > instances of pinmux_bias_reg: a first one with the puen field filled in,
> > listing pins with pull-up functionality, and a second one with the pud
> > field filled in, listing pins with pull-down functionality.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds