Re: [PATCH] media: rcar-csi2: Enable support for r8a77961

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] media: rcar-csi2: Enable support for r8a77961
Date: Tue, 23 Mar 2021 15:53:27 +0100	[thread overview]
Message-ID: <CAMuHMdXbhzzYUwiXg8h2KPdTb-c5peogDK_saGvDir36zNAq4w@mail.gmail.com> (raw)
In-Reply-To: <20210312132459.1754782-1-niklas.soderlund+renesas@ragnatech.se>

Hi Niklas,

On Fri, Mar 12, 2021 at 2:26 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Enable support for M3-W+ (r8a77961).
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Thanks for your patch!

> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -1164,6 +1164,10 @@ static const struct of_device_id rcar_csi2_of_table[] = {
>                 .compatible = "renesas,r8a7796-csi2",
>                 .data = &rcar_csi2_info_r8a7796,
>         },
> +       {
> +               .compatible = "renesas,r8a77961-csi2",
> +               .data = &rcar_csi2_info_r8a7796,

Hence CSI2 on R-Car M3-W+ is handled the same way as R-Car M3-W.
I don't know what this means for the driver, but according to Technical
Update TN-RCT-S0359A/E, R-Car M3-W+ supports lane settings 4/2/1 on
CSI40/41 (like most other R-Car Gen3 SoCs), while R-Car M3-W supports
only lane setting 4 on CSI40/41.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds