Re: [PATCH v2 0/5] PM / Domains: Remove gpd_dev_ops.active_wakeup() callback

From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Kevin Hilman <khilman@kernel.org>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	linux-mediatek@lists.infradead.org,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] PM / Domains: Remove gpd_dev_ops.active_wakeup() callback
Date: Thu, 2 Nov 2017 10:14:37 +0100	[thread overview]
Message-ID: <CAMuHMdXiZvKj8eJw1p=x3EQbKoJc_Q2R+D8YKvBgOO8VY=qr2Q@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFoVnWKSGncWD6fxNLgbpuz-weJhqjgptEset2S8F2A6AA@mail.gmail.com>

Hi Ulf,

On Wed, Nov 1, 2017 at 11:10 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:
> On 31 October 2017 at 19:11, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>> It is quite common for PM Domains to require slave devices to be kept
>> active during system suspend if they are to be used as wakeup sources.
>> To enable this, currently each PM Domain or driver has to provide its
>> own gpd_dev_ops.active_wakeup() callback.
>>
>> All existing callbacks either return always true, or a fixed value
>> depending on the PM Domain.
>>
>> Hence this patch series simplifies active wakeup handling by replacing
>> the callback by a flag:
>>   - Patch 1 adds a new new flag GENPD_FLAG_ACTIVE_WAKEUP, to be set by
>>     PM Domain drivers that want to use the new handling,
>>   - Patches 2-4 convert all existing users of the callback to the new
>>     flag,
>>   - Patch 5 removes the callback.
>>
>> This series was extracted from "[PATCH 00/10] PM / Domain: renesas: Fix
>> active wakeup behavior", and retains only PM Domain changes to existing
>> drivers.
>> Changes compared to v1 (most suggested by Ulf):
>>   - Use the flag in se instead of setting up an "always true" callback,
>>   - Convert the mediatek and rockchip PM Domain drivers,
>>   - Remove the callback.
>>
>> If this idea is accepted, I think it would be good to still queue the first
>> patch for v4.15.  That would allow the changes to the PM Domain drivers
>> to go in through the respective platform trees in v4.16.
>> Then the final patch has to be postponed until v4.17.
>> Alternatively, everything can go in through the PM tree in one shot.
>
> For the series:
>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Thanks!

> It's easier if everything goes via Rafael's PM tree. Moreover, this
> series is to me rather trivial, so I would actually recommend to pick
> it all for 4.15. Mainly because, moving too slowly forward, allows new
> users to show up of the callback you remove in patch5.

Obviously, that's fine for me.
Guess I've just became a bit too cautious with treewide changes ;-)

>>   [RFC] ARM: shmobile: pm-rmobile: Use GENPD_FLAG_ACTIVE_WAKEUP

We already have an ack from Simon...

>>   [RFC] soc: mediatek: Use GENPD_FLAG_ACTIVE_WAKEUP
>>   [RFC] soc: rockchip: power-domain: Use GENPD_FLAG_ACTIVE_WAKEUP

... we still need one for mediatek and rockchip?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds