Re: [PULL v3 0/1] Rtd patches - Marc-André Lureau

From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL v3 0/1] Rtd patches
Date: Sat, 15 May 2021 23:02:06 +0400	[thread overview]
Message-ID: <CAMxuvayho0Lgyejz8KPCDfmsbHZE9ANMdKv+NCdooUHoaJyY4Q@mail.gmail.com> (raw)
In-Reply-To: <48378522-0a28-b1c6-2a28-72c85202fcb2@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2436 bytes --]

Hi

On Sat, May 15, 2021 at 5:20 PM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:

> On 5/14/21 8:33 PM, Peter Maydell wrote:
> > On Fri, 14 May 2021 at 12:13, <marcandre.lureau@redhat.com> wrote:
> >>
> >> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >>
> >> The following changes since commit
> 2d3fc4e2b069494b1e9e2e4a1e3de24cbc036426:
> >>
> >>   Merge remote-tracking branch
> 'remotes/armbru/tags/pull-misc-2021-05-12' into staging (2021-05-13
> 20:13:24 +0100)
> >>
> >> are available in the Git repository at:
> >>
> >>   git@gitlab.com:marcandre.lureau/qemu.git tags/rtd-pull-request
> >>
> >> for you to fetch changes up to 73e6aec6522e1edd63f631c52577b49a39bc234f:
> >>
> >>   sphinx: adopt kernel readthedoc theme (2021-05-14 15:05:03 +0400)
> >>
> >> ----------------------------------------------------------------
> >> Pull request
> >>
> >> ----------------------------------------------------------------
> >
> >
> > Applied, thanks.
>
> After rebasing I'm getting:
>
> Program sphinx-build-3 found: YES
> docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3:
> Configuration error:
> There is a programmable error in your configuration file:
>
> Traceback (most recent call last):
>   File "/home/phil/source/qemu/docs/conf.py", line 155, in <module>
>     import sphinx_rtd_theme
> ModuleNotFoundError: No module named 'sphinx_rtd_theme'
>
> During handling of the above exception, another exception occurred:
>
> Traceback (most recent call last):
>   File "/usr/lib/python3.8/site-packages/sphinx/config.py", line 361, in
> eval_config_file
>     execfile_(filename, namespace)
>   File "/usr/lib/python3.8/site-packages/sphinx/util/pycompat.py", line
> 81, in execfile_
>     exec(code, _globals)
>   File "/home/phil/source/qemu/docs/conf.py", line 157, in <module>
>     raise ConfigError(
> sphinx.errors.ConfigError: The Sphinx 'sphinx_rtd_theme' HTML theme was
> not found.
>
> Is python3-sphinx_rtd_theme a required dependency now?
>
>
Yes, only If you --enable-docs. Otherwise, you should get a warning and doc
will be disabled. Mine is less ugly than yours, not sure why:

Program sphinx-build-3 found: YES (/usr/bin/sphinx-build-3)
../docs/meson.build:30: WARNING: /usr/bin/sphinx-build-3:
Configuration error:
The Sphinx 'sphinx_rtd_theme' HTML theme was not found.

Program python3 found: YES (/usr/bin/python3)

[-- Attachment #2: Type: text/html, Size: 3289 bytes --]