From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: linuxsea@163.com
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID:multitouch:add driver for CJTouch MultiTouch
Date: Mon, 6 Jul 2015 09:55:29 +0200 [thread overview]
Message-ID: <CAN+gG=FWp61uBBEUq3-Zk-4yLv4QBWc10k08Yj5oe6K-r8Af5A@mail.gmail.com> (raw)
In-Reply-To: <1436104612-3357-1-git-send-email-linuxsea@163.com>
On Sun, Jul 5, 2015 at 3:56 PM, <linuxsea@163.com> wrote:
> From: Yang Bo <linuxsea@163.com>
>
> Signed-off-by: Yang Bo <linuxsea@163.com>
> ---
> drivers/hid/Kconfig | 1 +
> drivers/hid/hid-ids.h | 4 ++++
> drivers/hid/hid-multitouch.c | 8 ++++++++
> 3 files changed, 13 insertions(+)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index cc4c664..57c94d7 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -480,6 +480,7 @@ config HID_MULTITOUCH
> - Atmel panels
> - Cando dual touch panels
> - Chunghwa panels
> + - CJTouch panels
> - CVTouch panels
> - Cypress TrueTouch panels
> - Elan Microelectronics touch panels
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index b04b082..591b7d0 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -236,6 +236,10 @@
>
> #define USB_VENDOR_ID_CIDC 0x1677
>
> +#define USB_VENDOR_ID_CJTOUCH 0x24b8
> +#define USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0020 0x0020
> +#define USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0040 0x0040
> +
> #define USB_VENDOR_ID_CMEDIA 0x0d8c
> #define USB_DEVICE_ID_CM109 0x000e
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 6a9b05b..5055008 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1138,6 +1138,14 @@ static const struct hid_device_id mt_devices[] = {
> MT_USB_DEVICE(USB_VENDOR_ID_CHUNGHWAT,
> USB_DEVICE_ID_CHUNGHWAT_MULTITOUCH) },
>
> + /* CJTouch panels */
> + { .driver_data = MT_CLS_DEFAULT,
> + HID_USB_DEVICE(USB_VENDOR_ID_CJTOUCH,
> + USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0020) },
> + { .driver_data = MT_CLS_DEFAULT,
> + HID_USB_DEVICE(USB_VENDOR_ID_CJTOUCH,
> + USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0040) },
> +
Just taking a few minutes while I am still on vacations...
NACK. If the devices work with the MT_CLS_DEFAULT class, there is no
point in adding them in the list of special devices.
This list should only contain the devices that requires special quirks
which is not the case here.
Thanks for the submission though!
Cheers,
Benjamin
> /* CVTouch panels */
> { .driver_data = MT_CLS_NSMU,
> MT_USB_DEVICE(USB_VENDOR_ID_CVTOUCH,
> --
> 1.7.9.5
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-07-06 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 13:56 [PATCH] HID:multitouch:add driver for CJTouch MultiTouch linuxsea
2015-07-06 7:55 ` Benjamin Tissoires [this message]
2015-07-20 16:40 linuxsea
2015-07-24 12:57 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN+gG=FWp61uBBEUq3-Zk-4yLv4QBWc10k08Yj5oe6K-r8Af5A@mail.gmail.com' \
--to=benjamin.tissoires@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxsea@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.