From: Kousik Sanagavarapu <five231003@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mark Brown <broonie@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>
Subject: [PATCH v2] spi: dt-bindings: jcore,spi: convert spi-jcore to dtschema
Date: Fri, 22 Mar 2024 12:03:33 +0530 [thread overview]
Message-ID: <CAN19-EdU5OPb=0Qz0_b3GxAJsjD_DAoVRrQM1+38p2SGVTAOgQ@mail.gmail.com> (raw)
In-Reply-To: <affc1b03-7a23-4fd8-bf85-4155bcd41df1@linaro.org>
On Fri, 22 Mar 2024, 11:33 Krzysztof Kozlowski,
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 21/03/2024 19:02, Kousik Sanagavarapu wrote:
>>
>> + spi-max-frequency:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>
> No, drop. From which other SPI binding did you take it? I asked you to
> look at existing code.
Without this, "make dt_binding_check" would break though, right at the
position in the example where "spi-max-frequency" is used. That was
also the reason why additionalProperties was set to true in the last
iteration, but after reading the doc more carefully I realized that was
wrong after you pointed it out.
I followed along bindings/spi/nvidia,tegra114-spi.yaml.
(Sorry for the HTML mail ping, I'm replying from mobile)
next prev parent reply other threads:[~2024-03-22 6:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 18:02 [PATCH v2] spi: dt-bindings: jcore,spi: convert spi-jcore to dtschema Kousik Sanagavarapu
2024-03-22 6:03 ` Krzysztof Kozlowski
2024-03-22 6:33 ` Kousik Sanagavarapu [this message]
[not found] ` <CAN19-EfCOWFqFCrF0iCaxhfZuteWawQoH0d6pTN3cgQ7p-CK6w@mail.gmail.com>
2024-03-22 6:34 ` Krzysztof Kozlowski
2024-03-22 6:49 ` Krzysztof Kozlowski
2024-03-22 15:05 ` Rob Herring
2024-03-22 16:48 ` Kousik Sanagavarapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN19-EdU5OPb=0Qz0_b3GxAJsjD_DAoVRrQM1+38p2SGVTAOgQ@mail.gmail.com' \
--to=five231003@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.