From: Andrea Merello <andrea.merello@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Matt Ranostay <matt.ranostay@konsulko.com>,
Alexandru Ardelean <ardeleanalex@gmail.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Andrea Merello <andrea.merello@iit.it>
Subject: Re: [v2 10/10] iio: imu: add BNO055 I2C driver
Date: Tue, 9 Nov 2021 12:56:43 +0100 [thread overview]
Message-ID: <CAN8YU5NiKz2JiNr-47OC4==N8L67HDshuH45BifnHBae+GUU-g@mail.gmail.com> (raw)
In-Reply-To: <85ef90ad-0d3a-6cb7-529f-667562b2ad71@infradead.org>
Il giorno ven 29 ott 2021 alle ore 00:04 Randy Dunlap
<rdunlap@infradead.org> ha scritto:
>
> On 10/28/21 3:18 AM, Andrea Merello wrote:
> > This path adds an I2C driver for communicating to a BNO055 IMU via I2C bus
> > and it enables the BNO055 core driver to work in this scenario.
> >
> > Signed-off-by: Andrea Merello <andrea.merello@iit.it>
> > ---
> > drivers/iio/imu/bno055/Kconfig | 6 ++++
> > drivers/iio/imu/bno055/Makefile | 1 +
> > drivers/iio/imu/bno055/bno055_i2c.c | 54 +++++++++++++++++++++++++++++
> > 3 files changed, 61 insertions(+)
> > create mode 100644 drivers/iio/imu/bno055/bno055_i2c.c
> >
> > diff --git a/drivers/iio/imu/bno055/Kconfig b/drivers/iio/imu/bno055/Kconfig
> > index 941e43f0368d..87200787d548 100644
> > --- a/drivers/iio/imu/bno055/Kconfig
> > +++ b/drivers/iio/imu/bno055/Kconfig
> > @@ -7,3 +7,9 @@ config BOSH_BNO055_SERIAL
> > tristate "Bosh BNO055 attached via serial bus"
> > depends on SERIAL_DEV_BUS
> > select BOSH_BNO055_IIO
> > +
> > +config BOSH_BNO055_I2C
> > + tristate "Bosh BNO055 attached via I2C bus"
> > + depends on I2C
> > + select REGMAP_I2C
> > + select BOSH_BNO055_IIO
>
> Hi,
>
> The config entries that have user prompt strings should also
> have help text. scripts/checkpatch.pl should have told you
> about that...
I'll add it, thanks. But FYI checkpatch doesn't complain about that here.
> --
> ~Randy
next prev parent reply other threads:[~2021-11-09 11:56 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 14:17 [PATCH 0/4] Add support for Bosch BNO055 IMU Andrea Merello
2021-07-15 14:17 ` [PATCH 1/4] iio: add modifiers for linear acceleration Andrea Merello
2021-07-17 14:32 ` Jonathan Cameron
2021-07-15 14:17 ` [PATCH 2/4] iio: imu: add Bosch Sensortec BNO055 core driver Andrea Merello
2021-07-15 16:49 ` Andy Shevchenko
2021-07-16 9:19 ` Andrea Merello
2021-07-16 12:39 ` Andy Shevchenko
2021-07-19 7:12 ` Andrea Merello
2021-07-19 10:33 ` Andrea Merello
2021-07-19 9:02 ` Andrea Merello
2021-07-19 11:48 ` Andy Shevchenko
2021-07-19 13:13 ` Andrea Merello
2021-07-16 7:24 ` Alexandru Ardelean
2021-07-16 9:49 ` Andrea Merello
2021-07-17 15:32 ` Jonathan Cameron
2021-07-19 8:30 ` Andrea Merello
2021-07-24 17:08 ` Jonathan Cameron
2021-07-26 14:36 ` Andrea Merello
2021-07-31 18:01 ` Jonathan Cameron
2021-08-04 10:06 ` Andrea Merello
2021-08-04 16:50 ` Jonathan Cameron
2021-08-04 19:27 ` Andy Shevchenko
2021-07-15 14:17 ` [PATCH 3/4] dt-bindings: iio: imu: add bosch BNO055 serdev driver bindings Andrea Merello
2021-07-17 15:39 ` Jonathan Cameron
2021-07-19 8:44 ` Andrea Merello
2021-07-15 14:17 ` [PATCH 4/4] iio: imu: add BNO055 serdev driver Andrea Merello
2021-07-15 17:08 ` kernel test robot
2021-07-15 17:08 ` kernel test robot
2021-07-15 18:14 ` kernel test robot
2021-07-15 18:14 ` kernel test robot
2021-07-17 15:50 ` Jonathan Cameron
2021-07-19 8:49 ` Andrea Merello
2021-07-19 11:55 ` Andy Shevchenko
2021-07-19 12:59 ` Andrea Merello
2021-07-19 14:15 ` Andy Shevchenko
2021-07-19 15:07 ` Andrea Merello
2021-10-28 10:18 ` [v2 00/10] Add support for Bosch BNO055 IMU Andrea Merello
2021-10-28 10:18 ` [v2 01/10] utils_macro: introduce find_closest_unsorted() Andrea Merello
2021-10-28 10:25 ` Andy Shevchenko
2021-11-08 11:05 ` Andrea Merello
2021-10-28 10:18 ` [v2 02/10] iio: document linear acceleration modifiers Andrea Merello
2021-10-28 10:31 ` Andy Shevchenko
2021-11-09 7:48 ` Andrea Merello
2021-10-28 10:40 ` Jonathan Cameron
2021-11-09 8:00 ` Andrea Merello
2021-11-09 17:00 ` Jonathan Cameron
2021-10-28 10:18 ` [v2 03/10] iio: document euler angles modifiers Andrea Merello
2021-10-28 10:33 ` Andy Shevchenko
2021-10-28 10:41 ` Jonathan Cameron
2021-11-09 8:15 ` Andrea Merello
2021-11-09 17:03 ` Jonathan Cameron
2021-10-28 10:18 ` [v2 04/10] iio: add modifiers for linear acceleration Andrea Merello
2021-10-28 10:45 ` Jonathan Cameron
2021-11-09 9:58 ` Andrea Merello
2021-11-09 17:05 ` Jonathan Cameron
2021-10-28 10:18 ` [v2 05/10] iio: add modifers for pitch, yaw, roll Andrea Merello
2021-10-28 10:47 ` Jonathan Cameron
2021-10-28 10:18 ` [v2 06/10] iio: document bno055 private sysfs attributes Andrea Merello
2021-10-28 11:04 ` Jonathan Cameron
2021-11-09 10:22 ` Andrea Merello
2021-11-14 16:20 ` Jonathan Cameron
2022-01-04 11:42 ` Andrea Merello
2022-01-15 15:27 ` Jonathan Cameron
2022-01-17 9:37 ` Andrea Merello
2022-01-22 18:08 ` Jonathan Cameron
2021-10-28 10:18 ` [v2 07/10] iio: imu: add Bosch Sensortec BNO055 core driver Andrea Merello
2021-10-28 13:31 ` Jonathan Cameron
2021-11-09 11:52 ` Andrea Merello
2021-11-14 16:33 ` Jonathan Cameron
2021-10-28 10:18 ` [v2 08/10] dt-bindings: iio: imu: add documentation for Bosch BNO055 bindings Andrea Merello
2021-10-28 12:25 ` Rob Herring
2021-10-28 10:18 ` [v2 09/10] iio: imu: add BNO055 serdev driver Andrea Merello
2021-10-28 12:31 ` Jonathan Cameron
2021-11-09 15:33 ` Andrea Merello
2021-11-14 16:37 ` Jonathan Cameron
2021-10-29 7:09 ` kernel test robot
2021-10-29 7:09 ` kernel test robot
2021-10-29 12:59 ` kernel test robot
2021-10-29 12:59 ` kernel test robot
2021-10-28 10:18 ` [v2 10/10] iio: imu: add BNO055 I2C driver Andrea Merello
2021-10-28 11:10 ` Jonathan Cameron
2021-11-11 10:12 ` Andrea Merello
2021-11-14 16:38 ` Jonathan Cameron
2021-10-28 22:04 ` Randy Dunlap
2021-11-09 11:56 ` Andrea Merello [this message]
2021-11-09 15:47 ` Randy Dunlap
2021-11-09 18:21 ` Joe Perches
2021-11-09 19:11 ` Randy Dunlap
2021-11-09 20:46 ` Joe Perches
2021-11-09 21:20 ` Randy Dunlap
2021-10-29 13:30 ` kernel test robot
2021-10-29 13:30 ` kernel test robot
2021-10-28 10:35 ` [v2 00/10] Add support for Bosch BNO055 IMU Jonathan Cameron
2021-10-28 10:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN8YU5NiKz2JiNr-47OC4==N8L67HDshuH45BifnHBae+GUU-g@mail.gmail.com' \
--to=andrea.merello@gmail.com \
--cc=andrea.merello@iit.it \
--cc=andy.shevchenko@gmail.com \
--cc=ardeleanalex@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=mchehab+huawei@kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.