From: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: jan.kiszka@siemens.com, kbingham@kernel.org,
akpm@linux-foundation.org, gregkh@linuxfoundation.org,
mingo@redhat.com, x86@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, vbabka@suse.cz
Subject: Re: [PATCH] scripts/gdb: add mm introspection utils
Date: Sat, 31 Dec 2022 20:14:30 +0300 [thread overview]
Message-ID: <CANXV_XzMVGHy5SP-2=QyO6YvpZAzLU4ZwFL3b8KOucr9rwkzhg@mail.gmail.com> (raw)
In-Reply-To: <Y69E0diWostgY2pj@kernel.org>
On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport <rppt@kernel.org> wrote:
>
> The commit message does not mention it's x86-specific.
> Not sure how gdb scripts handle per-arch functionality, but at the very
> least this should be stated in the commit message.
>
Thanks for pointing this out. Will fix it. I put the command's code
under the if utils.is_target_arch("x86") ... else
gdb.GdbError("Virtual address translation is not supported for this
arch") as it's done in other scripts and have plans to implement the
same functionality for ARM in the foreseeable future.
On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport <rppt@kernel.org> wrote:
> Any particular reason to make it ALL CAPS?
Actually, no. Do you propose to reformat the output with a lower case?
On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport <rppt@kernel.org> wrote:
> What will happen here with 5-level paging?
This is safe to do since the PS bit of PML5/PML4 is reserved and it's
not possible that a 5 or 4 level entry maps a page.
On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport <rppt@kernel.org> wrote:
> Please don't use magic numbers.
This was actually a page_offset_base in case the
CONFIG_DYNAMIC_MEMORY_LAYOUT option is disabled. Will fix it.
next prev parent reply other threads:[~2022-12-31 17:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 16:35 [PATCH] scripts/gdb: add mm introspection utils Dmitrii Bundin
2022-12-30 20:06 ` Mike Rapoport
2022-12-31 17:14 ` Dmitrii Bundin [this message]
2023-01-01 7:51 ` Mike Rapoport
2023-01-01 17:23 ` [PATCH v3] " Dmitrii Bundin
2023-01-02 8:59 ` Jan Kiszka
2023-01-02 17:10 ` [PATCH v4] " Dmitrii Bundin
2023-01-02 18:28 ` Mike Rapoport
2023-01-12 20:16 ` Greg KH
2023-01-13 17:51 ` [PATCH v5] " Dmitrii Bundin
2023-01-14 4:03 ` Andrew Morton
2022-12-30 21:37 ` [PATCH] " Andrew Morton
2022-12-31 17:26 ` Dmitrii Bundin
2022-12-31 17:12 ` [PATCH v2] " Dmitrii Bundin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANXV_XzMVGHy5SP-2=QyO6YvpZAzLU4ZwFL3b8KOucr9rwkzhg@mail.gmail.com' \
--to=dmitrii.bundin.a@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.