Re: [PATCH] drmif: add ABI for para-virtual DRM/KMS

From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Lars Kurth <lars.kurth@citrix.com>
Cc: "iurii.konovalenko@globallogic.com"
	<iurii.konovalenko@globallogic.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"vlad.babchuk@gmail.com" <vlad.babchuk@gmail.com>,
	Dario Faggioli <dario.faggioli@citrix.com>,
	"Tim (Xen.org)" <tim@xen.org>,
	"andrii.anisov@gmail.com" <andrii.anisov@gmail.com>,
	"olekstysh@gmail.com" <olekstysh@gmail.com>,
	"embedded-pv-devel@lists.xenproject.org"
	<embedded-pv-devel@lists.xenproject.org>,
	"al1img@gmail.com" <al1img@gmail.com>,
	David Vrabel <david.vrabel@citrix.com>,
	"JBeulich@suse.com" <JBeulich@suse.com>,
	Ian Jackson <Ian.Jackson@citrix.com>,
	"oleksandr.dmytryshyn@globallogic.com"
	<oleksandr.dmytryshyn@globallogic.com>,
	"joculator@gmail.com" <joculator@gmail.com>
Subject: Re: [PATCH] drmif: add ABI for para-virtual DRM/KMS
Date: Thu, 24 Nov 2016 17:38:49 +0200	[thread overview]
Message-ID: <CANY+8dc1qT4X7rtPsXSkdmmyNN0-R+9KEP_J547XTz2wGn8wwQ@mail.gmail.com> (raw)
In-Reply-To: <D45CAF89.308E0%lars.kurth@citrix.com>

Sorry about that, will fix

On Thu, Nov 24, 2016 at 5:05 PM, Lars Kurth <lars.kurth@citrix.com> wrote:
>
> Oleksandr,
>
>
> On 24/11/2016 11:30, "Oleksandr Andrushchenko" <andr2000@gmail.com> wrote:
>
>>This is the ABI for the two halves of a para-virtualized
>>DRM/KMS driver.
>>
>>Signed-off-by: Oleksandr Andrushchenko <andr2000@gmail.com>
>>Signed-off-by: Oleksandr Grytsov <al1img@gmail.com>
>
> ...
>
>>+ *
>>+ * Copyright (C) 2016 EPAM Systems Inc.
>>+ *
>>+ * Authors: Oleksandr Andrushchenko <andr2000@gmail.com>
>>+ *          Oleksandr Grytsov <al1img@gmail.com>
>>+ */
>
> I have a slight concern here about the use of private e-mail addresses in
> the Signed-off-by tags and authors field in the (c) notice. It contradicts
> "Copyright (C) 2016 EPAM Systems Inc." and will make it very hard to
> execute licenses changes, if that needs to be done in future.
>
> The Signed-off-by tag is a way to identify the (c) holder of a patch. I am
> assuming that in this case the (c) holder would be EPAM. Is this correct?
>
> If yes, please change the Signed-off-by: and author fields to an EPAM
> e-mail address. You can still send from gmail addresses though.
> If not, please change the "Copyright (C) 2016 EPAM Systems Inc."
> accordingly
>
> I am assuming there is a similar issue in the other patches.
> Please make sure you fix all of them.
>
> Best Regards
> Lars
>


-- 
Best regards,
Oleksandr Andrushchenko

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel