From: Christopher Li <sparse@chrisli.org>
To: Chris Forbes <chrisf@ijw.co.nz>
Cc: linux-sparse@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] check for identical exprs on LHS and RHS of '&&'
Date: Fri, 12 Aug 2011 12:16:11 -0700 [thread overview]
Message-ID: <CANeU7Qkpz7MAhcHrBxZ+u7mGfzBpTYhAHjHs_Jy_GQHfCvOppw@mail.gmail.com> (raw)
In-Reply-To: <1312967235-23817-1-git-send-email-chrisf@ijw.co.nz>
On Wed, Aug 10, 2011 at 2:07 AM, Chris Forbes <chrisf@ijw.co.nz> wrote:
> * Do people consider this a worthwhile check to make?
> * Am I "doing it right" with the expression walking?
> * Are there other cases which people would be interested in?
To evaluate a particular check, it is useful to look at the out come of the
check, and how complex it is the change.
e.g. How many the error caught by this check on some open source
projects. And how high is the false positive.
The expression walking is on the right track.
Chris
prev parent reply other threads:[~2011-08-12 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 9:07 [RFC PATCH 0/2] check for identical exprs on LHS and RHS of '&&' Chris Forbes
2011-08-10 9:07 ` [PATCH 1/2] add test case for identical exprs on LHS and RHS of '&&' operator Chris Forbes
2011-08-10 9:07 ` [PATCH 2/2] initial work on check for identical exprs on both sides of '&&'; needs more Chris Forbes
2011-08-10 17:44 ` [RFC PATCH 0/2] check for identical exprs on LHS and RHS of '&&' Josh Triplett
2011-08-10 17:46 ` Al Viro
2011-08-12 19:34 ` Dan Carpenter
2011-08-12 19:16 ` Christopher Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANeU7Qkpz7MAhcHrBxZ+u7mGfzBpTYhAHjHs_Jy_GQHfCvOppw@mail.gmail.com \
--to=sparse@chrisli.org \
--cc=chrisf@ijw.co.nz \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.