From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: James Morris <jmorris@namei.org>,
"Serge E . Hallyn" <serge@hallyn.com>,
Kees Cook <keescook@chromium.org>,
Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
Miguel Ojeda <ojeda@kernel.org>, Paul Moore <paul@paul-moore.com>,
Shuah Khan <shuah@kernel.org>, Tom Rix <trix@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-security-module <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v1 0/7] Landlock: Clean up coding style with clang-format
Date: Mon, 9 May 2022 11:06:38 +0200 [thread overview]
Message-ID: <CANiq72=SWen7sJxvQGD5N=ur-gpOiFGeHHfjegHxjaHfN_i95Q@mail.gmail.com> (raw)
In-Reply-To: <20220506160513.523257-1-mic@digikod.net>
Hi Mickaël,
(Answering in v1 since I want to quote something in this cover letter)
On Fri, May 6, 2022 at 6:03 PM Mickaël Salaün <mic@digikod.net> wrote:
>
> I used a simple coding style for the initial Landlock code. However,
> this may be subject to different interpretations. To avoid relying
> on tacit knowledge or text editors for these kind of rules, let's
> automate it as much as possible thanks to clang-format. This makes the
> code formatting simple, consistent and impersonal.
Thanks for moving your subsystem to `clang-format`. I am glad you
found it useful.
> Several versions of clang-format can be use but they may have (small)
> different behaviors for undefined/new configuration parts. After
> testing different versions, I picked clang-format-14 which is relatively
> new and fixes a bug present in version 11 to 13 (visible in the Landlock
> formatted code).
Which was the bug?
Cheers,
Miguel
next prev parent reply other threads:[~2022-05-09 9:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 16:05 [PATCH v1 0/7] Landlock: Clean up coding style with clang-format Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 1/7] landlock: Add clang-format exceptions Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 2/7] landlock: Format with clang-format Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 3/7] selftests/landlock: Add clang-format exceptions Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 4/7] selftests/landlock: Normalize array assignment Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 5/7] selftests/landlock: Format with clang-format Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 6/7] samples/landlock: Add clang-format exceptions Mickaël Salaün
2022-05-06 16:05 ` [PATCH v1 7/7] samples/landlock: Format with clang-format Mickaël Salaün
2022-05-09 9:06 ` Miguel Ojeda [this message]
2022-05-09 9:45 ` [PATCH v1 0/7] Landlock: Clean up coding style " Mickaël Salaün
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72=SWen7sJxvQGD5N=ur-gpOiFGeHHfjegHxjaHfN_i95Q@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=konstantin.meskhidze@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=ojeda@kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=shuah@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.