Re: [PATCH rdma-next] bnxt_re: Rely on Kconfig to keep module dependency

From: Devesh Sharma <devesh.sharma@broadcom.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	Doug Ledford <dledford@redhat.com>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
	Selvin Xavier <selvin.xavier@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Subject: Re: [PATCH rdma-next] bnxt_re: Rely on Kconfig to keep module dependency
Date: Wed, 24 Mar 2021 22:54:58 +0530	[thread overview]
Message-ID: <CANjDDBh_H1jqQxBJFgu-uO2AmWe4-3Qiuos93vxMPxHOx8md+w@mail.gmail.com> (raw)
In-Reply-To: <20210324165648.GL2356281@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

On Wed, Mar 24, 2021 at 10:26 PM Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> On Wed, Mar 24, 2021 at 10:00:05PM +0530, Devesh Sharma wrote:
>
> > > > > -static void bnxt_re_dev_unprobe(struct net_device *netdev,
> > > > > -                           struct bnxt_en_dev *en_dev)
> > > > > -{
> > > > > -   dev_put(netdev);
> > > > > -   module_put(en_dev->pdev->driver->driver.owner);
> > > > > -}
> > > >
> > > > And you are right to be wondering WTF is this
> >
> > Still trying to understand but what's the big idea here may be I can help.
>
> A driver should not have module put things like the above
>
> It should not be accessing ->driver without holding the device_lock()
>
> Basically it is all nonsense coding, Leon suggests to delete it and he
> is probably right.
>
> Can you explain what it thinks it is doing?
That F'ed up  code is trying to prevent a situation where someone
tries to remove the bnxt_en driver while bnxt_re driver is using it.
All because bnxt_re driver is at the mercy of bnxt_en drive and there
is not symbole dependence, Do you suggest anything to prevent that
unload of bnxt_en other than doing this jargon. I did not follow how
DEPENDS_ON would prevent things.
>
> Jason


-- 
-Regards
Devesh

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]