From: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
davem@davemloft.net, eric.dumazet@gmail.com,
netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next] tcp/dccp: bypass empty buckets in inet_twsk_purge()
Date: Fri, 29 Mar 2024 16:24:16 +0100 [thread overview]
Message-ID: <CANn89iJQ2HGbeufp=Kx3BketFt_D4u6sRo+qJae2syyzUricdA@mail.gmail.com> (raw)
In-Reply-To: <20240329080648.3cd12eaf@kernel.org>
On Fri, Mar 29, 2024 at 4:06 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 27 Mar 2024 12:29:34 -0700 Kuniyuki Iwashima wrote:
> > > - for (slot = 0; slot <= hashinfo->ehash_mask; slot++) {
> > > - struct inet_ehash_bucket *head = &hashinfo->ehash[slot];
> > > + for (slot = 0; slot <= ehash_mask; slot++, head++) {
> > > +
> >
> > unnecessary blank link here.
>
> I've seen some other core kernel contributors add empty lines after
> for or if statements, so I think this is intentional. Not sure why
> the empty line helps, either, TBH, but we have been letting it slide
> so far.
I will delete this extra line in the following patch, thanks !
next prev parent reply other threads:[~2024-03-29 15:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 19:12 [PATCH net-next] tcp/dccp: bypass empty buckets in inet_twsk_purge() Eric Dumazet
2024-03-27 19:29 ` Kuniyuki Iwashima
2024-03-29 15:06 ` Jakub Kicinski
2024-03-29 15:24 ` Eric Dumazet [this message]
2024-03-29 15:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iJQ2HGbeufp=Kx3BketFt_D4u6sRo+qJae2syyzUricdA@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.