From: Eric Dumazet <edumazet@google.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, dsahern@kernel.org, gal@nvidia.com
Subject: Re: [PATCH net] ipv6: Fix address dump when IPv6 is disabled on an interface
Date: Thu, 21 Mar 2024 18:47:47 +0100 [thread overview]
Message-ID: <CANn89iLZ2NoNCVTEa0pn510S1rW=eJu2z+ihSV6PzE2awWG7Pg@mail.gmail.com> (raw)
In-Reply-To: <20240321173042.2151756-1-idosch@nvidia.com>
On Thu, Mar 21, 2024 at 6:31 PM Ido Schimmel <idosch@nvidia.com> wrote:
>
> Cited commit started returning an error when user space requests to dump
> the interface's IPv6 addresses and IPv6 is disabled on the interface.
> Restore the previous behavior and do not return an error.
>
> Before cited commit:
>
> # ip address show dev dummy1
> 2: dummy1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN group default qlen 1000
> link/ether 1a:52:02:5a:c2:6e brd ff:ff:ff:ff:ff:ff
> inet6 fe80::1852:2ff:fe5a:c26e/64 scope link proto kernel_ll
> valid_lft forever preferred_lft forever
> # ip link set dev dummy1 mtu 1000
> # ip address show dev dummy1
> 2: dummy1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1000 qdisc noqueue state UNKNOWN group default qlen 1000
> link/ether 1a:52:02:5a:c2:6e brd ff:ff:ff:ff:ff:ff
>
> After cited commit:
>
> # ip address show dev dummy1
> 2: dummy1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN group default qlen 1000
> link/ether 1e:9b:94:00:ac:e8 brd ff:ff:ff:ff:ff:ff
> inet6 fe80::1c9b:94ff:fe00:ace8/64 scope link proto kernel_ll
> valid_lft forever preferred_lft forever
> # ip link set dev dummy1 mtu 1000
> # ip address show dev dummy1
> RTNETLINK answers: No such device
> Dump terminated
>
> With this patch:
>
> # ip address show dev dummy1
> 2: dummy1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN group default qlen 1000
> link/ether 42:35:fc:53:66:cf brd ff:ff:ff:ff:ff:ff
> inet6 fe80::4035:fcff:fe53:66cf/64 scope link proto kernel_ll
> valid_lft forever preferred_lft forever
> # ip link set dev dummy1 mtu 1000
> # ip address show dev dummy1
> 2: dummy1: <BROADCAST,NOARP,UP,LOWER_UP> mtu 1000 qdisc noqueue state UNKNOWN group default qlen 1000
> link/ether 42:35:fc:53:66:cf brd ff:ff:ff:ff:ff:ff
>
> Fixes: 9cc4cc329d30 ("ipv6: use xa_array iterator to implement inet6_dump_addr()")
> Reported-by: Gal Pressman <gal@nvidia.com>
> Closes: https://lore.kernel.org/netdev/7e261328-42eb-411d-b1b4-ad884eeaae4d@linux.dev/
> Tested-by: Gal Pressman <gal@nvidia.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> A similar change was done for IPv4 in commit cdb2f80f1c10 ("inet: use
> xa_array iterator to implement inet_dump_ifaddr()"), but I'm not aware
> of a way to disable IPv4 other than unregistering the interface, so I
> don't see a reason to change the IPv4 code.
> ---
Thanks for the fix.
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2024-03-21 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 17:30 [PATCH net] ipv6: Fix address dump when IPv6 is disabled on an interface Ido Schimmel
2024-03-21 17:47 ` Eric Dumazet [this message]
2024-03-23 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iLZ2NoNCVTEa0pn510S1rW=eJu2z+ihSV6PzE2awWG7Pg@mail.gmail.com' \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=gal@nvidia.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.