Re: [PATCH v5 0/5] lightnvm: Flexible metadata

From: Hans Holmberg <hans.ml.holmberg@owltronix.com>
To: igor.j.konopko@intel.com
Cc: Matias Bjorling <mb@lightnvm.io>,
	linux-block@vger.kernel.org,
	Javier Gonzalez <javier@cnexlabs.com>,
	Hans Holmberg <hans.holmberg@cnexlabs.com>
Subject: Re: [PATCH v5 0/5] lightnvm: Flexible metadata
Date: Mon, 3 Dec 2018 09:51:59 +0100	[thread overview]
Message-ID: <CANr-nt0NV61Rq9B19qeOHDN6gRGc76hdcxqQcgAVpysTBBEB8w@mail.gmail.com> (raw)
In-Reply-To: <CANr-nt33vO=egptfmCxDEdom5CKEEQ=NA1R5_z0Pe951-cPmSw@mail.gmail.com>

Great! The tests(rocksdb, pblk recovery and the generic xfs suite)
completed successfully on one of our disks, so feel free to add:

Tested-by: Hans Holmberg <hans.holmberg@cnexlabs.com>

Thanks,
Hans
On Fri, Nov 30, 2018 at 2:03 PM Hans Holmberg
<hans.ml.holmberg@owltronix.com> wrote:
>
> I just started a regression test on this patch set that'll run over
> the weekend. I'll add a tested-by if everything checks out.
>
> All the best,
> Hans
> On Fri, Nov 30, 2018 at 12:49 PM Igor Konopko <igor.j.konopko@intel.com> wrote:
> >
> > This series of patches extends the way how pblk can
> > store L2P sector metadata. After this set of changes
> > any size of NVMe metadata is supported in pblk.
> > Also there is an support for case without NVMe metadata.
> >
> > Changes v4 --> v5:
> > -rebase on top of ocssd/for-4.21/core
> >
> > Changes v3 --> v4:
> > -rename nvm_alloc_dma_pool() to nvm_create_dma_pool()
> > -split pblk_get_meta() calls and lba setting into
> > two operations for better core readability
> > -fixing compilation with CONFIG_NVM disabled
> > -getting rid of unnecessary memcpy for packed metadata
> > on write path
> > -support for drives with oob size >0 and <16B in packed
> > metadata mode
> > -minor commit message updates
> >
> > Changes v2 --> v3:
> > -Rebase on top of ocssd/for-4.21/core
> > -get/set_meta_lba helpers were removed
> > -dma reallocation was replaced with single allocation
> > -oob metadata size was added to pblk structure
> > -proper checks on pblk creation were added
> >
> > Changes v1 --> v2:
> > -Revert sector meta size back to 16b for pblk
> > -Dma pool for larger oob meta are handled in core instead of pblk
> > -Pblk oob meta helpers uses __le64 as input outpu instead of u64
> > -Other minor fixes based on v1 patch review
> >
> > Igor Konopko (5):
> >   lightnvm: pblk: Move lba list to partial read context
> >   lightnvm: pblk: Helpers for OOB metadata
> >   lightnvm: Flexible DMA pool entry size
> >   lightnvm: Disable interleaved metadata
> >   lightnvm: pblk: Support for packed metadata
> >
> >  drivers/lightnvm/core.c          |  9 ++++--
> >  drivers/lightnvm/pblk-core.c     | 61 +++++++++++++++++++++++++++++++------
> >  drivers/lightnvm/pblk-init.c     | 44 +++++++++++++++++++++++++--
> >  drivers/lightnvm/pblk-map.c      | 20 +++++++-----
> >  drivers/lightnvm/pblk-rb.c       |  3 ++
> >  drivers/lightnvm/pblk-read.c     | 66 +++++++++++++++++++++++-----------------
> >  drivers/lightnvm/pblk-recovery.c | 25 +++++++++------
> >  drivers/lightnvm/pblk-sysfs.c    |  7 +++++
> >  drivers/lightnvm/pblk-write.c    |  9 +++---
> >  drivers/lightnvm/pblk.h          | 24 +++++++++++++--
> >  drivers/nvme/host/lightnvm.c     |  6 ++--
> >  include/linux/lightnvm.h         |  3 +-
> >  12 files changed, 209 insertions(+), 68 deletions(-)
> >
> > --
> > 2.14.5
> >