From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: "Filipe Laíns" <lains@archlinux.org>
Cc: Pedro Vanzella <pedro@pedrovanzella.com>,
Bastien Nocera <hadess@hadess.net>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
Jiri Kosina <jikos@kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [Resubmit] Read battery voltage from Logitech Gaming mice
Date: Fri, 23 Aug 2019 17:32:24 +0200 [thread overview]
Message-ID: <CAO-hwJLQT6Oj2mvDTtQsOHLOTLFeB=_e6ZQZVj2tz92CZUU17A@mail.gmail.com> (raw)
In-Reply-To: <3c37ccc992d7979358e8472fbf52a583c6e1068f.camel@archlinux.org>
On Fri, Aug 23, 2019 at 4:48 PM Filipe Laíns <lains@archlinux.org> wrote:
>
> On Fri, 2019-08-23 at 16:32 +0200, Benjamin Tissoires wrote:
> > The problem I have with quirks, and that I explained to Filipe on IRC
> > is that this is kernel ABI. Even if there is a very low chance we have
> > someone using this, re-using the same drv_data bit in the future might
> > break someone's device.
>
> But we can reserve those bits. I don't expect there to be a ton of
> devices that need to be quirked, so using the remaining bits should be
> perfectly fine. Do you agree?
Nope. If the code is not ready for upstream, it should not be included.
Cheers,
Benjamin
next prev parent reply other threads:[~2019-08-23 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 20:18 [Resubmit] Read battery voltage from Logitech Gaming mice Pedro Vanzella
2019-08-22 20:18 ` [PATCH v3 1/4] hid-logitech-hidpp: add quirk to handle battery voltage Pedro Vanzella
2019-08-22 20:18 ` [PATCH v3 2/4] hid-logitech-hidpp: add function to query " Pedro Vanzella
2019-08-22 20:18 ` [PATCH v3 3/4] hid-logitech-hidpp: report battery voltage to the power supply Pedro Vanzella
2019-08-22 20:18 ` [PATCH v3 4/4] hid-logitech-hidpp: subscribe to battery voltage events Pedro Vanzella
2019-08-23 8:25 ` [Resubmit] Read battery voltage from Logitech Gaming mice Benjamin Tissoires
2019-08-23 14:22 ` Pedro Vanzella
2019-08-23 14:29 ` Filipe Laíns
2019-08-23 14:32 ` Benjamin Tissoires
2019-08-23 14:48 ` Filipe Laíns
2019-08-23 15:32 ` Benjamin Tissoires [this message]
2019-08-23 15:46 ` Pedro Vanzella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO-hwJLQT6Oj2mvDTtQsOHLOTLFeB=_e6ZQZVj2tz92CZUU17A@mail.gmail.com' \
--to=benjamin.tissoires@redhat.com \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=lains@archlinux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pedro@pedrovanzella.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.