Re: [PATCH v2] HID: logitech: Add MX Master 3 Mouse

From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Adrian Freund <adrian@freund.io>
Cc: "open list:HID CORE LAYER" <linux-input@vger.kernel.org>
Subject: Re: [PATCH v2] HID: logitech: Add MX Master 3 Mouse
Date: Tue, 22 Oct 2019 12:20:19 +0200	[thread overview]
Message-ID: <CAO-hwJLg1DQe0gAq-JHEcLBnq0hAmVeTN_T0SdrBHXLW0ArM7A@mail.gmail.com> (raw)
In-Reply-To: <20191020213307.217228-1-adrian@freund.io>

Hi Adrian,

On Sun, Oct 20, 2019 at 11:33 PM Adrian Freund <adrian@freund.io> wrote:
>
> Adds support for the Logitech MX Master 3 Mouse to the HID++ driver when
> connected by the Logitech Unifying Receiver.
> This doesn't yet add support for using the mouse over bluetooth.

well, patch looks good, but can you also add the BLE ID by rebasing on
top of https://patchwork.kernel.org/project/linux-input/list/?series=190445
?
I just requested a few changes on this series, but there should not be
major ones.

Cheers,
Benjamin

>
> Signed-off-by: Adrian Freund <adrian@freund.io>
> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index 0179f7ed77e5..e263085a0b82 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -3717,6 +3717,8 @@ static const struct hid_device_id hidpp_devices[] = {
>         { LDJ_DEVICE(0x4071), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
>         { /* Mouse Logitech MX Master 2S */
>           LDJ_DEVICE(0x4069), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
> +       { /* Mouse Logitech MX Master 3 */
> +         LDJ_DEVICE(0x4082), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_X2121 },
>         { /* Mouse Logitech Performance MX */
>           LDJ_DEVICE(0x101a), .driver_data = HIDPP_QUIRK_HI_RES_SCROLL_1P0 },
>         { /* Keyboard logitech K400 */
> --
> 2.23.0
>