From: Anatol Pomozov <anatol.pomozov@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Stephen Warren <swarren@nvidia.com>,
Bard Liao <bardliao@realtek.com>,
Laurent Dahan <ldahan@nvidia.com>, Dylan Reid <dgreid@google.com>
Subject: Re: [PATCH] ASoC: tegra: Add platform driver for rt5677 audio codec
Date: Tue, 6 Jan 2015 10:46:04 -0800 [thread overview]
Message-ID: <CAOMFOmWVwXF_S5UyeZG61VVRfxpQj=WmTe0Dm+SC4fxksWT9=Q@mail.gmail.com> (raw)
In-Reply-To: <20141229155532.GM17800@sirena.org.uk>
Hi
On Mon, Dec 29, 2014 at 7:55 AM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Dec 29, 2014 at 05:25:59AM -0800, Anatol Pomozov wrote:
>> On Fri, Dec 26, 2014 at 8:38 AM, Mark Brown <broonie@kernel.org> wrote:
>
>> >> +#if defined(CONFIG_MODULES) && defined(MODULE)
>> >> + request_module("snd_soc_tegra30_i2s");
>> >> +#endif
>
>> > What's this all about then?
>
>> Sorry, my question was not clear. I meant is it ok to put this
>> request_module() to upstream code? If not then just remove it before
>> merging my patch.
>
> What question, I'm not seeing a question in the patch (I'd expect it to
> be after the --- if one was being asked)? I've no idea what it's there
> for so it's hard to tell, my first thought would be no and you need to
> fix whatever you're working around directly.
My question was related to dependency between i2s and codec driver
modules. See it here (in the middle of the message)
http://permalink.gmane.org/gmane.linux.alsa.devel/132054
Anyway I think it is not worth spending too much time on it. I resent
this patch without request_module().
next prev parent reply other threads:[~2015-01-06 18:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 19:29 [PATCH] ASoC: tegra: Add platform driver for rt5677 audio codec Anatol Pomozov
2014-12-23 19:36 ` Anatol Pomozov
2014-12-26 16:38 ` Mark Brown
2014-12-29 13:25 ` Anatol Pomozov
2014-12-29 15:55 ` Mark Brown
2015-01-06 18:46 ` Anatol Pomozov [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-30 19:12 Anatol Pomozov
2015-01-07 18:54 ` Mark Brown
2014-10-15 21:15 Anatol Pomozov
2014-10-16 7:38 ` Mark Brown
2014-10-16 8:59 ` Anatol Pomazau
2014-10-16 9:04 ` Mark Brown
2014-09-30 21:52 [PATCH] ASoc: " Anatol Pomozov
2014-10-01 18:17 ` Mark Brown
2014-10-07 3:44 ` Stephen Warren
2014-10-07 5:29 ` Anatol Pomazau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMFOmWVwXF_S5UyeZG61VVRfxpQj=WmTe0Dm+SC4fxksWT9=Q@mail.gmail.com' \
--to=anatol.pomozov@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=dgreid@google.com \
--cc=ldahan@nvidia.com \
--cc=oder_chiou@realtek.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.