From: Fabio Estevam <festevam@gmail.com>
To: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Zeng Zhaoming <zhaoming.zeng@freescale.com>
Subject: Re: [PATCH v1] ASoC: sgtl5000: Fix noise on shutdown/remove
Date: Fri, 24 Jun 2022 07:29:54 -0300 [thread overview]
Message-ID: <CAOMZO5AmopdssNX9QhsO=_W+y-F3SYFR6LPuSCsH8=bkLaKHnQ@mail.gmail.com> (raw)
In-Reply-To: <20220624101301.441314-1-francesco.dolcini@toradex.com>
Hi Francesco,
On Fri, Jun 24, 2022 at 7:13 AM Francesco Dolcini
<francesco.dolcini@toradex.com> wrote:
>
> Put the SGTL5000 in a silent/safe state on shutdown/remove, this is
> required since the SGTL5000 produces a constant noise on its output
> after it is configured and its clock is removed. Without this change
> this is happening every time the module is unbound/removed or from
> reboot till the clock is enabled again.
>
> The issue was experienced on both a Toradex Colibri/Apalis iMX6, but can
> be easily reproduced everywhere just playing something on the codec and
> after that removing/unbinding the driver.
>
> Fixes: 9b34e6cc3bc2 ("ASoC: Add Freescale SGTL5000 codec support")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Thanks for the fix:
Reviewed-by: Fabio Estevam <festevam@denx.de>
next prev parent reply other threads:[~2022-06-24 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 10:13 [PATCH v1] ASoC: sgtl5000: Fix noise on shutdown/remove Francesco Dolcini
2022-06-24 10:29 ` Fabio Estevam [this message]
2022-06-24 14:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5AmopdssNX9QhsO=_W+y-F3SYFR6LPuSCsH8=bkLaKHnQ@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=francesco.dolcini@toradex.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
--cc=zhaoming.zeng@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.