From: Fabio Estevam <festevam@gmail.com>
To: Clark Wang <xiaoning.wang@nxp.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] spi: lpspi: add multi SS support in PIO mode
Date: Tue, 23 Apr 2019 08:21:34 -0300 [thread overview]
Message-ID: <CAOMZO5CQ04UiYPoVjT6L3MuK6cCLu01Ba=-uui_Lf7t58n1tqQ@mail.gmail.com> (raw)
In-Reply-To: <20190423104649.24483-3-xiaoning.wang@nxp.com>
On Tue, Apr 23, 2019 at 7:48 AM Clark Wang <xiaoning.wang@nxp.com> wrote:
>
> Add "fsl,spi-num-chipselects" check to support multi SS function in PIO
> mode.
This custom property does not seem to be needed as the number of chip
selects can be parsed from the devicetree file directly.
We got rid of "fsl,spi-num-chipselects" property in the spi-imx driver
in this commit:
commit b36581df7e788b674a4efbb8da7fe4a00c207e8b
Author: Alexander Shiyan <shc_work@mail.ru>
Date: Wed Jun 8 20:02:06 2016 +0300
spi: imx: Using existing properties for chipselects
Patch reuse existing "chip_select" and "cs_gpio(s)" fields from SPI core.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Signed-off-by: Mark Brown <broonie@kernel.org>
and we should try to also avoid such property in spi-fsl-lpspi as well.
next prev parent reply other threads:[~2019-04-23 11:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 10:46 [PATCH 0/3] spi: lpspi: SS function related changes Clark Wang
2019-04-23 10:46 ` [PATCH 1/3] spi: lpspi: add NULL check when probe device Clark Wang
2019-04-23 11:14 ` Fabio Estevam
2019-04-23 10:46 ` [PATCH 2/3] spi: lpspi: add multi SS support in PIO mode Clark Wang
2019-04-23 11:21 ` Fabio Estevam [this message]
2019-04-23 10:46 ` [PATCH 3/3] spi: lpspi: remove fsl_lpspi->chipselect Clark Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5CQ04UiYPoVjT6L3MuK6cCLu01Ba=-uui_Lf7t58n1tqQ@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.