From: Amir Goldstein <amir73il@gmail.com>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests <fstests@vger.kernel.org>, Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v2 2/2] tests: remove redundant common/$FSTYP importing
Date: Thu, 26 May 2022 09:51:01 +0300 [thread overview]
Message-ID: <CAOQ4uxg94oN6DyxCiM-x0_Kwtbpo0Cbi5yARDQxxOOODHLOrBg@mail.gmail.com> (raw)
In-Reply-To: <20220526012317.3624914-1-zlang@kernel.org>
On Thu, May 26, 2022 at 9:47 AM Zorro Lang <zlang@kernel.org> wrote:
>
> As fstests intensively source specific common/$FSTYP files in
> common/rc, at the beginning of ./check running. Each single case
> doesn't need to import that again.
>
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---
Looks fine.
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
>
> I removed "./common/filter" in btrfs/258 uncarefully, fix that in this V2.
>
> Thanks,
> Zorro
>
> tests/btrfs/177 | 1 -
> tests/btrfs/258 | 1 -
> tests/btrfs/259 | 1 -
> tests/xfs/422 | 1 -
> tests/xfs/423 | 1 -
> tests/xfs/517 | 1 -
> 6 files changed, 6 deletions(-)
>
> diff --git a/tests/btrfs/177 b/tests/btrfs/177
> index 2fd11e89..7b004b83 100755
> --- a/tests/btrfs/177
> +++ b/tests/btrfs/177
> @@ -10,7 +10,6 @@
> _begin_fstest auto quick swap balance
>
> . ./common/filter
> -. ./common/btrfs
>
> # Modify as appropriate.
> _supported_fs btrfs
> diff --git a/tests/btrfs/258 b/tests/btrfs/258
> index 158eaf79..da073333 100755
> --- a/tests/btrfs/258
> +++ b/tests/btrfs/258
> @@ -10,7 +10,6 @@
> . ./common/preamble
> _begin_fstest auto defrag quick
>
> -. ./common/btrfs
> . ./common/filter
>
> # real QA test starts here
> diff --git a/tests/btrfs/259 b/tests/btrfs/259
> index e7bd8ddd..92d0b9a6 100755
> --- a/tests/btrfs/259
> +++ b/tests/btrfs/259
> @@ -12,7 +12,6 @@ _begin_fstest auto quick defrag
>
> # Import common functions.
> . ./common/filter
> -. ./common/btrfs
>
> # real QA test starts here
>
> diff --git a/tests/xfs/422 b/tests/xfs/422
> index 77db492e..175253aa 100755
> --- a/tests/xfs/422
> +++ b/tests/xfs/422
> @@ -17,7 +17,6 @@ _register_cleanup "_cleanup" BUS
> . ./common/filter
> . ./common/fuzzy
> . ./common/inject
> -. ./common/xfs
>
> # real QA test starts here
> _supported_fs xfs
> diff --git a/tests/xfs/423 b/tests/xfs/423
> index be56f311..c9dfaece 100755
> --- a/tests/xfs/423
> +++ b/tests/xfs/423
> @@ -18,7 +18,6 @@ _register_cleanup "_cleanup" BUS
> . ./common/filter
> . ./common/fuzzy
> . ./common/inject
> -. ./common/xfs
>
> # real QA test starts here
> _supported_fs xfs
> diff --git a/tests/xfs/517 b/tests/xfs/517
> index 512f795f..88c4f43b 100755
> --- a/tests/xfs/517
> +++ b/tests/xfs/517
> @@ -23,7 +23,6 @@ _cleanup()
> . ./common/filter
> . ./common/fuzzy
> . ./common/inject
> -. ./common/xfs
>
> # real QA test starts here
> _supported_fs xfs
> --
> 2.31.1
>
prev parent reply other threads:[~2022-05-26 6:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 7:34 [PATCH 0/2] source fs specific common file properly Zorro Lang
2022-05-25 7:34 ` [PATCH 1/2] common: source base fs specific common file Zorro Lang
2022-05-26 6:39 ` Amir Goldstein
2022-05-25 7:34 ` [PATCH 2/2] tests: remove redundant common/$FSTYP importing Zorro Lang
2022-05-26 0:13 ` Dave Chinner
2022-05-26 1:14 ` Zorro Lang
2022-05-26 1:23 ` [PATCH v2 " Zorro Lang
2022-05-26 2:28 ` Dave Chinner
2022-05-26 6:51 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxg94oN6DyxCiM-x0_Kwtbpo0Cbi5yARDQxxOOODHLOrBg@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.