Re: [PATCH 18/18] mkfs: format bigtime filesystems

From: Amir Goldstein <amir73il@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 18/18] mkfs: format bigtime filesystems
Date: Tue, 18 Aug 2020 17:45:41 +0300	[thread overview]
Message-ID: <CAOQ4uxgL9cUm3wqbSgRnRC-uOpDAJ4_KaZA+3CUx5rLDLaY19A@mail.gmail.com> (raw)
In-Reply-To: <159770524797.3958786.6498012041319904192.stgit@magnolia>

On Tue, Aug 18, 2020 at 2:23 AM Darrick J. Wong <darrick.wong@oracle.com> wrote:
>
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Allow formatting with large timestamps.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Reviewed-by: Amir Goldstein <amir73il@gmail.com>

Other than one comment below...

> ---
>  man/man8/mkfs.xfs.8 |   16 ++++++++++++++++
>  mkfs/xfs_mkfs.c     |   24 +++++++++++++++++++++++-
>  2 files changed, 39 insertions(+), 1 deletion(-)
>
>
> diff --git a/man/man8/mkfs.xfs.8 b/man/man8/mkfs.xfs.8
> index 082f3ab6c063..7434b9f2b4cd 100644
> --- a/man/man8/mkfs.xfs.8
> +++ b/man/man8/mkfs.xfs.8
> @@ -154,6 +154,22 @@ valid
>  are:
>  .RS 1.2i
>  .TP
> +.BI bigtime= value
> +This option enables filesystems that can handle inode timestamps from December
> +1901 to July 2486, and quota timer expirations from January 1970 to July 2486.
> +The value is either 0 to disable the feature, or 1 to enable large timestamps.
> +.IP
> +If this feature is not enabled, the filesystem can only handle timestamps from
> +December 1901 to January 2038, and quota timers from January 1970 to February
> +2106.
> +.IP
> +By default,
> +.B mkfs.xfs
> +will not enable this feature.
> +If the option
> +.B \-m crc=0
> +is used, the large timestamp feature is not supported and is disabled.
> +.TP
>  .BI crc= value
>  This is used to create a filesystem which maintains and checks CRC information
>  in all metadata objects on disk. The value is either 0 to disable the feature,
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 037246effd70..f9f78a020092 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -120,6 +120,7 @@ enum {
>         M_RMAPBT,
>         M_REFLINK,
>         M_INOBTCNT,
> +       M_BIGTIME,
>         M_MAX_OPTS,
>  };
>
> @@ -667,6 +668,7 @@ static struct opt_params mopts = {
>                 [M_RMAPBT] = "rmapbt",
>                 [M_REFLINK] = "reflink",
>                 [M_INOBTCNT] = "inobtcount",
> +               [M_BIGTIME] = "bigtime",
>         },
>         .subopt_params = {
>                 { .index = M_CRC,
> @@ -703,6 +705,12 @@ static struct opt_params mopts = {
>                   .maxval = 1,
>                   .defaultval = 1,
>                 },
> +               { .index = M_BIGTIME,
> +                 .conflicts = { { NULL, LAST_CONFLICT } },
> +                 .minval = 0,
> +                 .maxval = 1,
> +                 .defaultval = 1,

                 .defaultval = 0 ?

Thanks,
Amir.