Re: [PATCH v2 2/2] fanotify: allow "weak" fsid when watching a single filesystem

From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Christian Brauner <brauner@kernel.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] fanotify: allow "weak" fsid when watching a single filesystem
Date: Thu, 30 Nov 2023 19:23:21 +0200	[thread overview]
Message-ID: <CAOQ4uxgRTA9v66MkvcPaKjs3QrH0m09NhWr5+LfZoyJWXKd8ng@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxgJAZ3z5pgbfH+hNGj1G9EWQxQ4Hz4h+9X0xTktdiqsWA@mail.gmail.com>

On Thu, Nov 30, 2023 at 7:18 PM Amir Goldstein <amir73il@gmail.com> wrote:
>
> On Thu, Nov 30, 2023 at 7:12 PM Jan Kara <jack@suse.cz> wrote:
> >
> > On Thu 30-11-23 18:56:19, Amir Goldstein wrote:
> > > So far, fanotify returns -ENODEV or -EXDEV when trying to set a mark
> > > on a filesystem with a "weak" fsid, namely, zero fsid (e.g. fuse), or
> > > non-uniform fsid (e.g. btrfs non-root subvol).
> > >
> > > When group is watching inodes all from the same filesystem (or subvol),
> > > allow adding inode marks with "weak" fsid, because there is no ambiguity
> > > regarding which filesystem reports the event.
> > >
> > > The first mark added to a group determines if this group is single or
> > > multi filesystem, depending on the fsid at the path of the added mark.
> > >
> > > If the first mark added has a "strong" fsid, marks with "weak" fsid
> > > cannot be added and vice versa.
> > >
> > > If the first mark added has a "weak" fsid, following marks must have
> > > the same "weak" fsid and the same sb as the first mark.
> > >
> > > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> >
> > Yep, this is good. Can you please repost the whole series so that b4 can
> > easily pick it up from the list ;)? Thanks!
>
> hmm. I posted all but they did not hit the list :-/
> now reposted.

damnit! only the first REPOST patch hit the list,
but the first v2 patch now trickled.

You can get it from github if you prefer:
https://github.com/amir73il/linux/commits/fanotify_fsid

Thanks,
Amir.