From: Amir Goldstein <amir73il@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Eryu Guan <eguan@redhat.com>, Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH v3 9/9] overlay: mount/unmount base fs before/after running tests
Date: Tue, 14 Feb 2017 19:55:46 +0200 [thread overview]
Message-ID: <CAOQ4uxgV++ZdecBfUth2TN4A451hP_7UXRkBkgVhOTEwCzhNMA@mail.gmail.com> (raw)
In-Reply-To: <20170214170757.nuhxnvhtctreelxt@thunk.org>
On Tue, Feb 14, 2017 at 7:07 PM, Theodore Ts'o <tytso@mit.edu> wrote:
> On Tue, Feb 14, 2017 at 08:43:36AM +0200, Amir Goldstein wrote:
>>
>> Correct. The only thing that overlay does not do is format the base fs,
>> as the README says:
>> - for overlay tests: ./check -overlay [test(s)]
>> The TEST and SCRATCH partitions should be pre-formatted
>> with another base fs, where the overlay dirs will be created
>>
>
> So this means that if I only want to do the equivalent of:
>
> gce-xfstests -c overlay generic/013
>
> as part of a bisection search, it's impossible to do this via the
> config file and "./check -s ext4-overlay generic/013" alone. Someone
> who wants to do this will have to use their own wrapper script to
> format the base file system with the proper file system.
>
> Correct?
>
Correct.
I guess it wouldn't be that hard to add mkfs/fsck support for base fs,
but for now my budget to deal with this is over. I may get to it another
time.
> Which is fine, I have my own wrapper script system. :-)
>
Do we have something like:
./check -s ext4 --setup-only
Should we have something like this?
Will this do the trick?
./check -s ext4 -n generic/013
next prev parent reply other threads:[~2017-02-14 17:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 20:43 [PATCH v3 0/9] fstests: new way to run overlay tests Amir Goldstein
2017-02-12 20:43 ` [PATCH v3 1/9] fstests: sanity check that test partitions are not mounted elsewhere Amir Goldstein
2017-02-13 11:10 ` Eryu Guan
2017-02-13 11:44 ` Amir Goldstein
2017-02-13 13:33 ` Amir Goldstein
2017-02-14 5:51 ` Eryu Guan
2017-02-14 6:02 ` Amir Goldstein
2017-02-14 7:23 ` Eryu Guan
2017-02-14 8:05 ` Amir Goldstein
2017-02-16 8:53 ` Amir Goldstein
2017-02-12 20:43 ` [PATCH v3 2/9] fstests: use _test_mount() consistently Amir Goldstein
2017-02-13 11:17 ` Eryu Guan
2017-02-12 20:43 ` [PATCH v3 3/9] fstests: canonicalize mount points on every config section Amir Goldstein
2017-02-12 20:43 ` [PATCH v3 4/9] overlay: rename OVERLAY_LOWER/UPPER/WORK_DIR Amir Goldstein
2017-02-12 20:43 ` [PATCH v3 5/9] overlay: allow SCRATCH_DEV to be the base fs mount point Amir Goldstein
2017-02-12 20:43 ` [PATCH v3 6/9] overlay: configure TEST/SCRATCH vars to base fs Amir Goldstein
2017-02-13 11:28 ` Eryu Guan
2017-02-13 20:31 ` Amir Goldstein
2017-02-14 11:03 ` Eryu Guan
2017-02-15 14:59 ` Amir Goldstein
2017-02-12 20:43 ` [PATCH v3 7/9] overlay: use OVL_BASE_SCRATCH_MNT instead of SCRATCH_DEV Amir Goldstein
2017-02-12 20:43 ` [PATCH v3 8/9] overlay: fix test and scratch filters for overlay base fs Amir Goldstein
2017-02-13 20:39 ` Amir Goldstein
2017-02-12 20:43 ` [PATCH v3 9/9] overlay: mount/unmount base fs before/after running tests Amir Goldstein
2017-02-13 11:31 ` Eryu Guan
2017-02-13 11:59 ` Amir Goldstein
2017-02-14 0:23 ` Theodore Ts'o
2017-02-14 5:24 ` Eryu Guan
2017-02-14 6:43 ` Amir Goldstein
2017-02-14 17:07 ` Theodore Ts'o
2017-02-14 17:55 ` Amir Goldstein [this message]
2017-02-16 8:50 ` Amir Goldstein
2017-02-12 20:51 ` [PATCH v3 0/9] fstests: new way to run overlay tests Amir Goldstein
2017-02-13 4:19 ` Xiong Zhou
2017-02-13 5:37 ` Amir Goldstein
2017-02-14 4:40 ` Xiong Zhou
2017-02-14 6:15 ` Amir Goldstein
2017-02-14 9:25 ` Xiong Zhou
2017-02-14 9:51 ` Amir Goldstein
2017-02-13 11:02 ` Eryu Guan
2017-02-16 9:02 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxgV++ZdecBfUth2TN4A451hP_7UXRkBkgVhOTEwCzhNMA@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.