Re: [5.15] MAINTAINERS: add Leah as xfs maintainer for 5.15.y

From: Amir Goldstein <amir73il@gmail.com>
To: Leah Rumancik <leah.rumancik@gmail.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>,
	"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [5.15] MAINTAINERS: add Leah as xfs maintainer for 5.15.y
Date: Thu, 30 Jun 2022 08:31:03 +0300	[thread overview]
Message-ID: <CAOQ4uxh-2c0Sp=nUN-brB3ySb_rhYPLPa-VxJW9WOzSXOLUCww@mail.gmail.com> (raw)
In-Reply-To: <20220629235546.3843096-1-leah.rumancik@gmail.com>

On Thu, Jun 30, 2022 at 3:11 AM Leah Rumancik <leah.rumancik@gmail.com> wrote:
>
> Update MAINTAINERS for xfs in an effort to help direct bots/questions
> about xfs in 5.15.y.
>
> Note: 5.10.y [1] and 5.4.y will have different updates to their
> respective MAINTAINERS files for this effort.
>
> Suggested-by: Darrick J. Wong <djwong@kernel.org>
> Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
>
> [1] https://lore.kernel.org/linux-xfs/20220629213236.495647-1-amir73il@gmail.com/

It is not good practice to put stuff after the commit message trailer.
Greg's signature is going to be after that line.
In this case, I think you could simply drop the [1] reference
it's not important in git historic perspective.

You could add the references after --- if you like.

Thanks,
Amir.

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 393706e85ba2..a60d7e0466af 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20579,6 +20579,7 @@ F:      drivers/xen/*swiotlb*
>
>  XFS FILESYSTEM
>  C:     irc://irc.oftc.net/xfs
> +M:     Leah Rumancik <leah.rumancik@gmail.com>
>  M:     Darrick J. Wong <djwong@kernel.org>
>  M:     linux-xfs@vger.kernel.org
>  L:     linux-xfs@vger.kernel.org
> --
> 2.37.0.rc0.161.g10f37bed90-goog
>