From: Amir Goldstein <amir73il@gmail.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Leah Rumancik <leah.rumancik@gmail.com>,
Chandan Babu R <chandan.babu@oracle.com>,
linux-xfs <linux-xfs@vger.kernel.org>,
fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH 5.10 CANDIDATE 0/4] xfs stable candidate patches for 5.10.y (from v5.15)
Date: Tue, 9 Aug 2022 18:29:33 +0200 [thread overview]
Message-ID: <CAOQ4uxh6vqnLtTVonPtns-zDfi5+-R8MJ=nrtgqusuVV8DWPgw@mail.gmail.com> (raw)
In-Reply-To: <YvKLJMq+thXk6wsW@magnolia>
On Tue, Aug 9, 2022 at 6:28 PM Darrick J. Wong <djwong@kernel.org> wrote:
>
> On Tue, Aug 09, 2022 at 01:17:04PM +0200, Amir Goldstein wrote:
> > Hi Darrick,
> >
> > This is a small update of simple backports from v5.15 that shouldn't be
> > too hard to review.
> >
> > I rather take "remove support for disabling quota accounting" to 5.10.y
> > even though it is not a proper bug fix, as a defensive measure and in
> > order to match the expefctations of fstests from diabling quota.
>
> I don't agree with making quotaoff a nop after 136 releases of the 5.10
> series. Turning off quota accounting on a running system might be
> risky, but anyone who's using it in 5.10 most likely expects it to
> continue working, infrequent warts and all.
>
OK.
> > These backports survived the standard auto group soak for over 40 runs
> > on the 5 test configs.
> >
> > Please ACK.
>
> Patches 2-4 are straightforward fixes, so:
> Acked-by: Darrick J. Wong <djwong@kernel.org>
>
Thanks,
Amir.
prev parent reply other threads:[~2022-08-09 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 11:17 [PATCH 5.10 CANDIDATE 0/4] xfs stable candidate patches for 5.10.y (from v5.15) Amir Goldstein
2022-08-09 11:17 ` [PATCH 5.10 CANDIDATE 1/4] xfs: remove support for disabling quota accounting on a mounted file system Amir Goldstein
2022-08-09 11:17 ` [PATCH 5.10 CANDIDATE 2/4] mm: Add kvrealloc() Amir Goldstein
2022-08-09 11:17 ` [PATCH 5.10 CANDIDATE 3/4] xfs: only set IOMAP_F_SHARED when providing a srcmap to a write Amir Goldstein
2022-08-09 11:17 ` [PATCH 5.10 CANDIDATE 4/4] xfs: fix I_DONTCACHE Amir Goldstein
2022-08-09 16:28 ` [PATCH 5.10 CANDIDATE 0/4] xfs stable candidate patches for 5.10.y (from v5.15) Darrick J. Wong
2022-08-09 16:29 ` Amir Goldstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxh6vqnLtTVonPtns-zDfi5+-R8MJ=nrtgqusuVV8DWPgw@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=leah.rumancik@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.