From: Amir Goldstein <amir73il@gmail.com>
To: Dave Chinner <david@fromorbit.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH 7/8] fstests: Set up BUS trap for tests by default
Date: Tue, 24 May 2022 11:48:00 +0300 [thread overview]
Message-ID: <CAOQ4uxhe6DKQAkZAZLyLXhmsULxpDi3yj+-vD9KN0wVsH8j_kw@mail.gmail.com> (raw)
In-Reply-To: <20220524073411.1943480-8-david@fromorbit.com>
On Tue, May 24, 2022 at 11:08 AM Dave Chinner <david@fromorbit.com> wrote:
>
> From: Dave Chinner <dchinner@redhat.com>
>
> About 160 individual tests re-register the cleanup trap just to have
> it run on a BUS error signal. Just add the BUS signal to the default
> set of traps initialised by _register_cleanup() and get rid of these
> extra registrations.
>
> This was mostly done with this script:
>
> $ for f in `git grep -l "register_cleanup.*BUS"` ; do
> > sed -i -e '/_register_cleanup "_cleanup" BUS/,+1d'
> > done
>
> With a small number of non-matching conversions done by hand.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> common/preamble | 4 ++--
> tests/ext4/023 | 2 --
> tests/generic/161 | 2 --
> tests/generic/162 | 2 --
> tests/generic/163 | 2 --
> tests/generic/164 | 2 --
> tests/generic/165 | 2 --
> tests/generic/166 | 2 --
> tests/generic/167 | 2 --
> tests/generic/168 | 2 --
> tests/generic/170 | 2 --
> tests/generic/247 | 2 --
> tests/generic/333 | 2 --
> tests/generic/334 | 2 --
> tests/generic/349 | 2 --
> tests/generic/350 | 2 --
> tests/generic/351 | 2 --
> tests/generic/356 | 2 --
> tests/generic/357 | 2 --
> tests/generic/358 | 2 --
> tests/generic/359 | 2 --
> tests/generic/372 | 2 --
> tests/generic/373 | 2 --
> tests/generic/374 | 2 --
> tests/generic/414 | 2 --
> tests/generic/425 | 2 --
> tests/generic/553 | 2 --
> tests/generic/554 | 2 --
> tests/generic/564 | 2 --
> tests/generic/565 | 2 --
> tests/generic/670 | 2 --
> tests/generic/671 | 2 --
> tests/generic/672 | 2 --
> tests/xfs/017 | 2 --
> tests/xfs/138 | 2 --
> tests/xfs/162 | 2 --
> tests/xfs/262 | 2 --
> tests/xfs/280 | 2 --
> tests/xfs/285 | 2 --
> tests/xfs/286 | 2 --
> tests/xfs/349 | 2 --
> tests/xfs/350 | 2 --
> tests/xfs/351 | 2 --
> tests/xfs/352 | 2 --
> tests/xfs/353 | 2 --
> tests/xfs/354 | 2 --
> tests/xfs/355 | 2 --
> tests/xfs/356 | 2 --
> tests/xfs/357 | 2 --
> tests/xfs/358 | 2 --
> tests/xfs/359 | 2 --
> tests/xfs/360 | 2 --
> tests/xfs/361 | 2 --
> tests/xfs/362 | 2 --
> tests/xfs/363 | 2 --
> tests/xfs/364 | 2 --
> tests/xfs/365 | 2 --
> tests/xfs/366 | 2 --
> tests/xfs/367 | 2 --
> tests/xfs/368 | 2 --
> tests/xfs/369 | 2 --
> tests/xfs/370 | 2 --
> tests/xfs/371 | 2 --
> tests/xfs/372 | 2 --
> tests/xfs/373 | 2 --
> tests/xfs/374 | 2 --
> tests/xfs/375 | 2 --
> tests/xfs/376 | 2 --
> tests/xfs/377 | 2 --
> tests/xfs/378 | 2 --
> tests/xfs/379 | 2 --
> tests/xfs/380 | 2 --
> tests/xfs/381 | 2 --
> tests/xfs/382 | 2 --
> tests/xfs/383 | 2 --
> tests/xfs/384 | 2 --
> tests/xfs/385 | 2 --
> tests/xfs/386 | 2 --
> tests/xfs/387 | 2 --
> tests/xfs/388 | 2 --
> tests/xfs/389 | 2 --
> tests/xfs/390 | 2 --
> tests/xfs/391 | 2 --
> tests/xfs/392 | 2 --
> tests/xfs/393 | 2 --
> tests/xfs/394 | 2 --
> tests/xfs/395 | 2 --
> tests/xfs/396 | 2 --
> tests/xfs/397 | 2 --
> tests/xfs/398 | 2 --
> tests/xfs/399 | 2 --
> tests/xfs/400 | 2 --
> tests/xfs/401 | 2 --
> tests/xfs/402 | 2 --
> tests/xfs/403 | 2 --
> tests/xfs/404 | 2 --
> tests/xfs/405 | 2 --
> tests/xfs/406 | 2 --
> tests/xfs/407 | 2 --
> tests/xfs/408 | 2 --
> tests/xfs/409 | 2 --
> tests/xfs/410 | 2 --
> tests/xfs/411 | 2 --
> tests/xfs/412 | 2 --
> tests/xfs/413 | 2 --
> tests/xfs/414 | 2 --
> tests/xfs/415 | 2 --
> tests/xfs/416 | 2 --
> tests/xfs/417 | 2 --
> tests/xfs/418 | 2 --
> tests/xfs/422 | 2 --
> tests/xfs/423 | 2 --
> tests/xfs/425 | 2 --
> tests/xfs/426 | 2 --
> tests/xfs/427 | 2 --
> tests/xfs/428 | 2 --
> tests/xfs/429 | 2 --
> tests/xfs/430 | 2 --
> tests/xfs/444 | 2 --
> tests/xfs/453 | 2 --
> tests/xfs/454 | 2 --
> tests/xfs/455 | 2 --
> tests/xfs/456 | 2 --
> tests/xfs/457 | 2 --
> tests/xfs/458 | 2 --
> tests/xfs/459 | 2 --
> tests/xfs/460 | 2 --
> tests/xfs/461 | 2 --
> tests/xfs/462 | 2 --
> tests/xfs/463 | 2 --
> tests/xfs/464 | 2 --
> tests/xfs/465 | 2 --
> tests/xfs/466 | 2 --
> tests/xfs/467 | 2 --
> tests/xfs/468 | 2 --
> tests/xfs/469 | 2 --
> tests/xfs/470 | 2 --
> tests/xfs/471 | 2 --
> tests/xfs/472 | 2 --
> tests/xfs/473 | 2 --
> tests/xfs/474 | 2 --
> tests/xfs/475 | 2 --
> tests/xfs/476 | 2 --
> tests/xfs/477 | 2 --
> tests/xfs/478 | 2 --
> tests/xfs/479 | 2 --
> tests/xfs/480 | 2 --
> tests/xfs/481 | 2 --
> tests/xfs/482 | 2 --
> tests/xfs/483 | 2 --
> tests/xfs/484 | 2 --
> tests/xfs/485 | 2 --
> tests/xfs/486 | 2 --
> tests/xfs/487 | 2 --
> tests/xfs/488 | 2 --
> tests/xfs/489 | 2 --
> tests/xfs/495 | 2 --
> tests/xfs/496 | 2 --
> tests/xfs/497 | 2 --
> tests/xfs/498 | 2 --
> tests/xfs/499 | 2 --
> tests/xfs/503 | 2 +-
> tests/xfs/507 | 2 +-
> tests/xfs/517 | 2 +-
> 164 files changed, 5 insertions(+), 325 deletions(-)
>
Nice cleanup!
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Thanks,
Amir.
next prev parent reply other threads:[~2022-05-24 8:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:34 [RFC PATCH 0/8] fstests: _cleanup() overrides are a mess Dave Chinner
2022-05-24 7:34 ` [PATCH 1/8] generic/038: kill background threads on interrupt Dave Chinner
2022-05-24 9:41 ` Amir Goldstein
2022-05-24 12:10 ` Dave Chinner
2022-05-24 12:30 ` Amir Goldstein
2022-05-24 7:34 ` [PATCH 2/8] fstests: _cleanup overrides are messy Dave Chinner
2022-05-24 16:16 ` Amir Goldstein
2022-05-24 7:34 ` [PATCH 3/8] xfs/*: clean up _cleanup override Dave Chinner
2022-05-24 10:42 ` Amir Goldstein
2022-05-24 12:27 ` Dave Chinner
2022-05-24 12:55 ` Amir Goldstein
2022-05-24 13:24 ` Dave Chinner
2022-05-24 14:17 ` Amir Goldstein
2022-05-24 16:32 ` Zorro Lang
2022-05-24 23:34 ` Dave Chinner
2022-05-25 2:54 ` Amir Goldstein
2022-05-24 17:13 ` Zorro Lang
2022-05-26 15:04 ` Zorro Lang
2022-05-26 23:39 ` Dave Chinner
2022-05-24 7:34 ` [PATCH 4/8] fstests: define a common _dump_cleanup function Dave Chinner
2022-05-24 9:04 ` Amir Goldstein
2022-05-24 9:52 ` Dave Chinner
2022-05-24 9:59 ` Amir Goldstein
2022-05-24 7:34 ` [PATCH 5/8] fstests: use a common fsstress cleanup function Dave Chinner
2022-05-24 12:25 ` Amir Goldstein
2022-05-24 7:34 ` [PATCH 6/8] fstests: consolidate no cleanup test setup Dave Chinner
2022-05-24 12:22 ` Amir Goldstein
2022-05-24 13:07 ` Dave Chinner
2022-05-24 7:34 ` [PATCH 7/8] fstests: Set up BUS trap for tests by default Dave Chinner
2022-05-24 8:48 ` Amir Goldstein [this message]
2022-05-24 7:34 ` [PATCH 8/8] fstests: cleanup _cleanup usage in shared Dave Chinner
2022-05-24 10:49 ` Amir Goldstein
2022-05-24 11:11 ` Amir Goldstein
2022-05-24 8:29 ` [RFC PATCH 0/8] fstests: _cleanup() overrides are a mess Amir Goldstein
2022-05-24 9:57 ` Dave Chinner
2022-05-24 10:01 ` Amir Goldstein
2022-05-24 10:13 ` Dave Chinner
2022-05-24 12:14 ` Amir Goldstein
2022-05-24 12:28 ` Dave Chinner
2022-05-24 12:34 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxhe6DKQAkZAZLyLXhmsULxpDi3yj+-vD9KN0wVsH8j_kw@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.