From: Amir Goldstein <amir73il@gmail.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] fanotify: allow "weak" fsid when watching a single filesystem
Date: Mon, 20 Nov 2023 18:20:46 +0200 [thread overview]
Message-ID: <CAOQ4uxiNan-gtL=WLEA=2O8zL0ttc0sd7UhxTB_95PEcbSsT6g@mail.gmail.com> (raw)
In-Reply-To: <20231120-langsam-eindecken-2cc8ba9954b6@brauner>
On Mon, Nov 20, 2023 at 5:48 PM Christian Brauner <brauner@kernel.org> wrote:
>
> > OOPS, missed fsnotify_put_mark(mark);
> > better add a goto target out_put_mark as this is the second case now.
>
> I want to point out that going forward we should be able to make use of
> scoped cleanup macros. Please see include/linux/cleanup.h. I think we
> should start making liberal use of this. I know that Peter Ziljstra is
> already doing so for kernel/sched/.
Yeh, I like them, but not sure if I would use them in this case.
Thanks,
Amir.
next prev parent reply other threads:[~2023-11-20 16:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 18:30 [PATCH 0/2] Support fanotify FAN_REPORT_FID on all filesystems Amir Goldstein
2023-11-18 18:30 ` [PATCH 1/2] fanotify: store fsid in mark instead of in connector Amir Goldstein
2023-11-30 14:25 ` Jan Kara
2023-11-30 15:29 ` Amir Goldstein
2023-11-30 15:50 ` Jan Kara
2023-11-18 18:30 ` [PATCH 2/2] fanotify: allow "weak" fsid when watching a single filesystem Amir Goldstein
2023-11-20 7:42 ` Amir Goldstein
2023-11-20 15:48 ` Christian Brauner
2023-11-20 16:20 ` Amir Goldstein [this message]
2023-11-21 13:33 ` Amir Goldstein
2023-11-30 12:42 ` Amir Goldstein
2023-11-30 15:47 ` Jan Kara
2023-11-30 16:28 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxiNan-gtL=WLEA=2O8zL0ttc0sd7UhxTB_95PEcbSsT6g@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.