From: Amir Goldstein <amir73il@gmail.com>
To: Oliver Sang <oliver.sang@intel.com>,
Christian Brauner <brauner@kernel.org>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, ying.huang@intel.com,
feng.tang@intel.com, fengwei.yin@intel.com
Subject: Re: [linus:master] [remap_range] dfad37051a: stress-ng.file-ioctl.ops_per_sec -11.2% regression
Date: Tue, 6 Feb 2024 17:04:56 +0200 [thread overview]
Message-ID: <CAOQ4uxjFA=P8ZiPjaqP-4Ka35GdqEtKaTTG1XMnts6rOswchCA@mail.gmail.com> (raw)
In-Reply-To: <Zb8vk1Psust0ODrs@xsang-OptiPlex-9020>
On Sun, Feb 4, 2024 at 8:33 AM Oliver Sang <oliver.sang@intel.com> wrote:
>
> hi, Amir,
>
> On Fri, Feb 02, 2024 at 11:13:56AM +0200, Amir Goldstein wrote:
> > On Wed, Jan 31, 2024 at 5:47 PM Amir Goldstein <amir73il@gmail.com> wrote:
> > >
> > > On Wed, Jan 31, 2024 at 4:13 PM kenel test robot <oliver.sang@intel.com> wrote:
> > > >
> > > >
> > > >
> > > > Hello,
> > > >
> > > > kernel test robot noticed a -11.2% regression of stress-ng.file-ioctl.ops_per_sec on:
> > > >
> > > >
> > > > commit: dfad37051ade6ac0d404ef4913f3bd01954ee51c ("remap_range: move permission hooks out of do_clone_file_range()")
> > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > > >
> > >
> > > Can you please try this fix:
> > >
> > > 7d4213664bda remap_range: move sanity checks out of do_clone_file_range()
> > >
> > > from:
> > >
> > > https://github.com/amir73il/linux ovl-fixes
> > >
> >
> > Sorry, Oliver, this was a buggy commit.
> > I pushed this fixes version to ovl-fixes branch:
> >
> > 1c5e7db8e1b2 remap_range: merge do_clone_file_range() into
> > vfs_clone_file_range()
> >
> > Can you please test.
>
> the regression disappeared by above commit in our tests.
>
> I noticed this branch is based on v6.8-rc2, so I directly tested upon it and its
> parent (3f01e53bf6). I found 3f01e53bf6 has same data as dfad37051a we reported.
>
> and on 1c5e7db8e1b2, the performance back to the same level before dfad37051a.
>
Thanks for testing!
Christian, can you please amend the fix commit to
Reported-and-tested-by: kernel test robot <oliver.sang@intel.com>
Thanks,
Amir.
next prev parent reply other threads:[~2024-02-06 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 14:13 [linus:master] [remap_range] dfad37051a: stress-ng.file-ioctl.ops_per_sec -11.2% regression kenel test robot
2024-01-31 15:47 ` Amir Goldstein
2024-02-02 9:13 ` Amir Goldstein
2024-02-04 6:32 ` Oliver Sang
2024-02-06 15:04 ` Amir Goldstein [this message]
2024-02-06 16:08 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxjFA=P8ZiPjaqP-4Ka35GdqEtKaTTG1XMnts6rOswchCA@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=feng.tang@intel.com \
--cc=fengwei.yin@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.