From: Oliver Upton <oupton@google.com>
To: Reiji Watanabe <reijiw@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Peter Shier <pshier@google.com>,
Ricardo Koller <ricarkol@google.com>,
Jing Zhang <jingzhangos@google.com>,
Raghavendra Rao Anata <rananta@google.com>
Subject: Re: [PATCH] arm64: arm64_ftr_reg->name may not be a human-readable string
Date: Mon, 1 Nov 2021 09:59:48 -0700 [thread overview]
Message-ID: <CAOQ_Qsj4jXs=5XaLfmTzw+WwthapCRfKATJLRSqiQvJ5LkCBbA@mail.gmail.com> (raw)
In-Reply-To: <20211101045421.2215822-1-reijiw@google.com>
On Sun, Oct 31, 2021 at 9:54 PM Reiji Watanabe <reijiw@google.com> wrote:
>
> The id argument of ARM64_FTR_REG_OVERRIDE() is used for two purposes:
> one as the system register encoding (used for the sys_id field of
> __ftr_reg_entry), and the other as the register name (stringified
> and used for the name field of arm64_ftr_reg), which is debug
> information. The id argument is supposed to be a macro that
> indicates an encoding of the register (eg. SYS_ID_AA64PFR0_EL1, etc).
>
> ARM64_FTR_REG(), which also has the same id argument,
> uses ARM64_FTR_REG_OVERRIDE() and passes the id to the macro.
> Since the id argument is completely macro-expanded before it is
> substituted into a macro body of ARM64_FTR_REG_OVERRIDE(),
> the stringified id in the body of ARM64_FTR_REG_OVERRIDE is not
> a human-readable register name, but a string of numeric bitwise
> operations.
>
> Fix this so that human-readable register names are available as
> debug information.
>
> Fixes: 8f266a5d878a ("arm64: cpufeature: Add global feature override facility")
> Signed-off-by: Reiji Watanabe <reijiw@google.com>
Reviewed-by: Oliver Upton <oupton@google.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-01 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 4:54 [PATCH] arm64: arm64_ftr_reg->name may not be a human-readable string Reiji Watanabe
2021-11-01 10:25 ` Marc Zyngier
2021-11-01 16:59 ` Oliver Upton [this message]
2021-11-03 17:08 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ_Qsj4jXs=5XaLfmTzw+WwthapCRfKATJLRSqiQvJ5LkCBbA@mail.gmail.com' \
--to=oupton@google.com \
--cc=catalin.marinas@arm.com \
--cc=jingzhangos@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=pshier@google.com \
--cc=rananta@google.com \
--cc=reijiw@google.com \
--cc=ricarkol@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.