From: Curtis Malainey <cujomalainey@google.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
ALSA development <alsa-devel@alsa-project.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
Jie Yang <yang.jie@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Paul Olaru <paul.olaru@oss.nxp.com>,
Curtis Malainey <cujomalainey@chromium.org>,
Rander Wang <rander.wang@intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Matt Davis <mattedavis@google.com>, Brent Lu <brent.lu@intel.com>
Subject: Re: [PATCH v2] ASoC: Intel: Fix platform ID matching
Date: Tue, 10 Aug 2021 17:40:30 -0600 [thread overview]
Message-ID: <CAOReqxg3MOUeE+9j+Ph8CDy-6X2CjYMUsLvRqEex2M1XGkFffw@mail.gmail.com> (raw)
In-Reply-To: <ac87ebd8-d10e-450d-80bb-3fe29554b73e@intel.com>
On Tue, Aug 10, 2021 at 5:23 AM Cezary Rojewski
<cezary.rojewski@intel.com> wrote:
>
> On 2021-08-09 11:35 PM, Curtis Malainey wrote:
> > Sparse warnings triggered truncating the IDs of some platform device
> > tables. Unfortunately some of the IDs in the match tables were missed
> > which breaks audio. The KBL change has been verified to fix audio, the
> > CML change was not tested as it was found through grepping the broken
> > changes and found to match the same situation in anticipation that it
> > should also be fixed.
> >
> > Fixes: 94efd726b947 ("ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters")
> > Fixes: 24e46fb811e9 ("ASoC: Intel: bxt_da7219_max98357a: shrink platform_id below 20 characters")
> > Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
> > Tested-by: Matt Davis <mattedavis@google.com>
>
> Thanks for the update, Curtis.
>
> This is still missing Suggested-by tag from my previous review.
> As kbl bits were tested by Lukasz it would be good to have his Tested-by
> tag too.
>
> With said tags appended:
>
> Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Ah i was not privy to that patch, this bug was found independently on
another board. Thanks for the heads up though.
>
>
> Regards,
> Czarek
next prev parent reply other threads:[~2021-08-10 23:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 21:35 [PATCH v2] ASoC: Intel: Fix platform ID matching Curtis Malainey
2021-08-09 22:10 ` Pierre-Louis Bossart
2021-08-10 11:22 ` Cezary Rojewski
2021-08-10 23:40 ` Curtis Malainey [this message]
2021-08-10 15:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOReqxg3MOUeE+9j+Ph8CDy-6X2CjYMUsLvRqEex2M1XGkFffw@mail.gmail.com \
--to=cujomalainey@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=cujomalainey@chromium.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mattedavis@google.com \
--cc=paul.olaru@oss.nxp.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.