From: Yu Zhao <yuzhao@google.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Yosry Ahmed <yosryahmed@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCHv4 0/4] zsmalloc: fine-grained fullness and new compaction algorithm
Date: Sun, 16 Apr 2023 01:20:37 -0600 [thread overview]
Message-ID: <CAOUHufZ6jPLJYeshO8=2TaqXRmpOFuMQ92E9sg-oCh54fkqW7g@mail.gmail.com> (raw)
In-Reply-To: <20230304034835.2082479-1-senozhatsky@chromium.org>
On Fri, Mar 3, 2023 at 8:48 PM Sergey Senozhatsky
<senozhatsky@chromium.org> wrote:
>
> Hi,
>
> Existing zsmalloc page fullness grouping leads to suboptimal page
> selection for both zs_malloc() and zs_compact(). This patchset
> reworks zsmalloc fullness grouping/classification.
>
> Additinally it also implements new compaction algorithm that is
> expected to use less CPU-cycles (as it potentially does fewer
> memcpy-s in zs_object_copy()).
>
> Test (synthetic) results can be seen in patch 0003.
Seeing the following crashes from mm-unstable. Please take a look. Thanks.
list_add corruption. next is NULL.
kernel BUG at lib/list_debug.c:26!
Call Trace:
<TASK>
zs_compact+0xbf6/0xda0
zs_shrinker_scan+0x19/0x30
do_shrink_slab+0x1ac/0x450
shrink_slab+0xdc/0x3d0
shrink_one+0xe2/0x1d0
shrink_node+0xc7f/0xea0
do_try_to_free_pages+0x1b5/0x500
try_to_free_pages+0x396/0x5d0
__alloc_pages_slowpath+0x5d0/0x1030
__alloc_pages+0x1de/0x280
__folio_alloc+0x1e/0x40
vma_alloc_folio+0x4c0/0x530
shmem_alloc_and_acct_folio+0x1a6/0x3b0
shmem_get_folio_gfp+0x689/0xf00
shmem_fault+0x81/0x240
next prev parent reply other threads:[~2023-04-16 7:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 3:48 [PATCHv4 0/4] zsmalloc: fine-grained fullness and new compaction algorithm Sergey Senozhatsky
2023-03-04 3:48 ` [PATCHv4 1/4] zsmalloc: remove insert_zspage() ->inuse optimization Sergey Senozhatsky
2023-03-04 3:48 ` [PATCHv4 2/4] zsmalloc: fine-grained inuse ratio based fullness grouping Sergey Senozhatsky
2023-03-04 3:48 ` [PATCHv4 3/4] zsmalloc: rework compaction algorithm Sergey Senozhatsky
2023-04-17 5:01 ` [PATCH] zsmalloc: reset compaction source zspage pointer after putback_zspage() Sergey Senozhatsky
2023-04-17 5:11 ` Yu Zhao
2023-04-17 11:43 ` Yosry Ahmed
2023-04-17 13:07 ` Sergey Senozhatsky
2023-04-17 13:08 ` Sergey Senozhatsky
2023-03-04 3:48 ` [PATCHv4 4/4] zsmalloc: show per fullness group class stats Sergey Senozhatsky
2023-03-10 21:10 ` [PATCHv4 0/4] zsmalloc: fine-grained fullness and new compaction algorithm Minchan Kim
2023-03-11 8:30 ` Sergey Senozhatsky
2023-04-16 7:20 ` Yu Zhao [this message]
2023-04-16 15:18 ` Sergey Senozhatsky
2023-04-16 19:27 ` Yu Zhao
2023-04-17 2:44 ` Sergey Senozhatsky
2023-04-17 2:55 ` Yu Zhao
2023-04-17 3:52 ` Sergey Senozhatsky
2023-04-17 8:29 ` Yosry Ahmed
2023-04-17 11:12 ` Sergey Senozhatsky
2023-04-17 11:16 ` Yosry Ahmed
2023-04-17 11:24 ` Sergey Senozhatsky
2023-04-17 11:31 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOUHufZ6jPLJYeshO8=2TaqXRmpOFuMQ92E9sg-oCh54fkqW7g@mail.gmail.com' \
--to=yuzhao@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.