From: Michael Ira Krufky <mkrufky@linuxtv.org>
To: Brad Love <brad@nextdimension.cc>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH 5/9] em28xx: Add Hauppauge SoloHD/DualHD bulk models
Date: Thu, 4 Jan 2018 19:24:22 -0500 [thread overview]
Message-ID: <CAOcJUbwsu7Nmr7=8KxMy8zFTgT+=fF3XH3v7Uy8cMPv4tweYaw@mail.gmail.com> (raw)
In-Reply-To: <1515110659-20145-6-git-send-email-brad@nextdimension.cc>
On Thu, Jan 4, 2018 at 7:04 PM, Brad Love <brad@nextdimension.cc> wrote:
> Add additional pids to driver list
>
> Signed-off-by: Brad Love <brad@nextdimension.cc>
:+1
Reviewed-by: Michael Ira Krufky <mkrufky@linuxtv.org>
> ---
> drivers/media/usb/em28xx/em28xx-cards.c | 22 +++++++++++++++++-----
> 1 file changed, 17 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
> index 7f5d0b28..34c693a 100644
> --- a/drivers/media/usb/em28xx/em28xx-cards.c
> +++ b/drivers/media/usb/em28xx/em28xx-cards.c
> @@ -507,8 +507,10 @@ static struct em28xx_reg_seq plex_px_bcud[] = {
> };
>
> /*
> - * 2040:0265 Hauppauge WinTV-dualHD DVB
> - * 2040:026d Hauppauge WinTV-dualHD ATSC/QAM
> + * 2040:0265 Hauppauge WinTV-dualHD DVB Isoc
> + * 2040:8265 Hauppauge WinTV-dualHD DVB Bulk
> + * 2040:026d Hauppauge WinTV-dualHD ATSC/QAM Isoc
> + * 2040:826d Hauppauge WinTV-dualHD ATSC/QAM Bulk
> * reg 0x80/0x84:
> * GPIO_0: Yellow LED tuner 1, 0=on, 1=off
> * GPIO_1: Green LED tuner 1, 0=on, 1=off
> @@ -2391,7 +2393,8 @@ struct em28xx_board em28xx_boards[] = {
> .has_dvb = 1,
> },
> /*
> - * 2040:0265 Hauppauge WinTV-dualHD (DVB version).
> + * 2040:0265 Hauppauge WinTV-dualHD (DVB version) Isoc.
> + * 2040:8265 Hauppauge WinTV-dualHD (DVB version) Bulk.
> * Empia EM28274, 2x Silicon Labs Si2168, 2x Silicon Labs Si2157
> */
> [EM28174_BOARD_HAUPPAUGE_WINTV_DUALHD_DVB] = {
> @@ -2407,7 +2410,8 @@ struct em28xx_board em28xx_boards[] = {
> .leds = hauppauge_dualhd_leds,
> },
> /*
> - * 2040:026d Hauppauge WinTV-dualHD (model 01595 - ATSC/QAM).
> + * 2040:026d Hauppauge WinTV-dualHD (model 01595 - ATSC/QAM) Isoc.
> + * 2040:826d Hauppauge WinTV-dualHD (model 01595 - ATSC/QAM) Bulk.
> * Empia EM28274, 2x LG LGDT3306A, 2x Silicon Labs Si2157
> */
> [EM28174_BOARD_HAUPPAUGE_WINTV_DUALHD_01595] = {
> @@ -2549,8 +2553,12 @@ struct usb_device_id em28xx_id_table[] = {
> .driver_info = EM2883_BOARD_HAUPPAUGE_WINTV_HVR_850 },
> { USB_DEVICE(0x2040, 0x0265),
> .driver_info = EM28174_BOARD_HAUPPAUGE_WINTV_DUALHD_DVB },
> + { USB_DEVICE(0x2040, 0x8265),
> + .driver_info = EM28174_BOARD_HAUPPAUGE_WINTV_DUALHD_DVB },
> { USB_DEVICE(0x2040, 0x026d),
> .driver_info = EM28174_BOARD_HAUPPAUGE_WINTV_DUALHD_01595 },
> + { USB_DEVICE(0x2040, 0x826d),
> + .driver_info = EM28174_BOARD_HAUPPAUGE_WINTV_DUALHD_01595 },
> { USB_DEVICE(0x0438, 0xb002),
> .driver_info = EM2880_BOARD_AMD_ATI_TV_WONDER_HD_600 },
> { USB_DEVICE(0x2001, 0xf112),
> @@ -2611,7 +2619,11 @@ struct usb_device_id em28xx_id_table[] = {
> .driver_info = EM28178_BOARD_PCTV_461E },
> { USB_DEVICE(0x2013, 0x025f),
> .driver_info = EM28178_BOARD_PCTV_292E },
> - { USB_DEVICE(0x2040, 0x0264), /* Hauppauge WinTV-soloHD */
> + { USB_DEVICE(0x2040, 0x0264), /* Hauppauge WinTV-soloHD Isoc */
> + .driver_info = EM28178_BOARD_PCTV_292E },
> + { USB_DEVICE(0x2040, 0x8264), /* Hauppauge OEM Generic WinTV-soloHD Bulk */
> + .driver_info = EM28178_BOARD_PCTV_292E },
> + { USB_DEVICE(0x2040, 0x8268), /* Hauppauge Retail WinTV-soloHD Bulk */
> .driver_info = EM28178_BOARD_PCTV_292E },
> { USB_DEVICE(0x0413, 0x6f07),
> .driver_info = EM2861_BOARD_LEADTEK_VC100 },
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-01-05 0:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 0:04 [PATCH 0/9] Hauppauge em28xx/lgdt3306a soloHD/DualHD support Brad Love
2018-01-05 0:04 ` [PATCH 1/9] em28xx: Hauppauge DualHD second tuner functionality Brad Love
2018-01-05 0:21 ` Michael Ira Krufky
2018-01-05 0:04 ` [PATCH 2/9] em28xx: Bulk transfer implementation fix Brad Love
2018-01-05 0:22 ` Michael Ira Krufky
2018-01-05 14:20 ` Devin Heitmueller
2018-01-05 15:21 ` Brad Love
2018-01-30 19:56 ` Brad Love
2018-01-30 12:07 ` Mauro Carvalho Chehab
2018-01-30 19:33 ` Brad Love
2018-02-01 22:04 ` [PATCH v2 " Brad Love
2018-01-05 0:04 ` [PATCH 3/9] em28xx: USB bulk packet size fix Brad Love
2018-01-05 0:23 ` Michael Ira Krufky
2018-01-05 0:04 ` [PATCH 4/9] em28xx: Increase max em28xx boards to max dvb adapters Brad Love
2018-01-05 0:23 ` Michael Ira Krufky
2018-01-05 0:04 ` [PATCH 5/9] em28xx: Add Hauppauge SoloHD/DualHD bulk models Brad Love
2018-01-05 0:24 ` Michael Ira Krufky [this message]
2018-01-05 0:04 ` [PATCH 6/9] em28xx: Enable Hauppauge SoloHD rebranded 292e SE Brad Love
2018-01-05 0:24 ` Michael Ira Krufky
2018-01-05 0:04 ` [PATCH 7/9] lgdt3306a: Set fe ops.release to NULL if probed Brad Love
2018-01-05 0:19 ` Michael Ira Krufky
2018-01-05 1:37 ` Brad Love
2018-01-09 5:17 ` Matthias Schwarzott
2018-01-09 13:00 ` Michael Ira Krufky
2018-01-05 0:04 ` [PATCH 8/9] lgdt3306a: QAM streaming improvement Brad Love
2018-01-05 0:26 ` Michael Ira Krufky
2018-01-05 1:34 ` Brad Love
2018-01-05 1:30 ` [PATCH v2 " Brad Love
2018-01-05 11:57 ` Michael Ira Krufky
2018-01-05 0:04 ` [PATCH 9/9] lgdt3306a: Add QAM AUTO support Brad Love
2018-01-05 0:27 ` Michael Ira Krufky
2018-02-12 20:52 ` [PATCH v2 " Brad Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOcJUbwsu7Nmr7=8KxMy8zFTgT+=fF3XH3v7Uy8cMPv4tweYaw@mail.gmail.com' \
--to=mkrufky@linuxtv.org \
--cc=brad@nextdimension.cc \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.