All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Dryomov <idryomov@gmail.com>
To: David Disseldorp <ddiss@suse.de>
Cc: Ceph Development <ceph-devel@vger.kernel.org>,
	Alex Elder <elder@linaro.org>
Subject: Re: [PATCH 0/2] rbd_img_obj_exists_submit() fixes
Date: Thu, 15 Sep 2016 13:53:59 +0200	[thread overview]
Message-ID: <CAOi1vP-XqpYFVsS26w_gm+vJygmiS848TjXEv79V80Ytjzdpig@mail.gmail.com> (raw)
In-Reply-To: <20160915124805.20590455@echidna.suse.de>

On Thu, Sep 15, 2016 at 12:48 PM, David Disseldorp <ddiss@suse.de> wrote:
> On Thu,  1 Sep 2016 16:59:17 +0200, David Disseldorp wrote:
>
>> Hi,
>>
>> This patchset fixes a couple of bugs in the rbd_img_obj_exists_submit()
>> code-path which appear to have been there since the function was first
>> added.
>>
>> Feedback appreciated.
>
> Did anyone get a chance to look at these changes?

Hi David,

I was waiting for Alex to take a look, but then realized that there is
more to fix: img_request is also getting leaked and we can ignore
ceph_osdc_start_request return value, simplifying things.

For the invalid union field use issue, I think we can just skip calling
rbd_osd_req_format_read() for !img_data requests, but I need to double
check.

I'll put together a branch my version of these fixes and ping you.

Thanks,

                Ilya

  reply	other threads:[~2016-09-15 11:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01 14:59 [PATCH 0/2] rbd_img_obj_exists_submit() fixes David Disseldorp
2016-09-01 14:59 ` [PATCH 1/2] rbd: fix invalid img_request dereference David Disseldorp
2016-09-01 14:59 ` [PATCH 2/2] rbd: fix rbd_img_obj_exists_submit() error path David Disseldorp
2016-09-15 10:48 ` [PATCH 0/2] rbd_img_obj_exists_submit() fixes David Disseldorp
2016-09-15 11:53   ` Ilya Dryomov [this message]
2016-09-15 12:25     ` Alex Elder
2016-09-19 17:06     ` Ilya Dryomov
2016-09-19 22:25       ` David Disseldorp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOi1vP-XqpYFVsS26w_gm+vJygmiS848TjXEv79V80Ytjzdpig@mail.gmail.com \
    --to=idryomov@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=ddiss@suse.de \
    --cc=elder@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.