From: Ilya Dryomov <idryomov@gmail.com>
To: Alex Elder <elder@ieee.org>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH 4/5] libceph: validate blob_struct_v in process_one_ticket()
Date: Tue, 23 May 2017 20:40:43 +0200 [thread overview]
Message-ID: <CAOi1vP9StiPi6ThbC68KUymNgLx1JorQ2OmqLGKtnAQBk+pfNw@mail.gmail.com> (raw)
In-Reply-To: <acf57851-8c0e-ca92-d7c4-13ae945983c0@ieee.org>
On Tue, May 23, 2017 at 7:44 PM, Alex Elder <elder@ieee.org> wrote:
> On 05/23/2017 11:33 AM, Ilya Dryomov wrote:
>> None of these are validated in userspace, but since we do validate
>> reply_struct_v in ceph_x_proc_ticket_reply(), tkt_struct_v (first) and
>> CephXServiceTicket struct_v (second) in process_one_ticket(), validate
>> CephXTicketBlob struct_v as well.
>>
>> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
>
> Looks good. (I don't know what's valid but I know you do.)
All those auth structs are v1. Thanks for the review!
Ilya
next prev parent reply other threads:[~2017-05-23 18:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 16:33 [PATCH 0/5] libceph: trivial warning fixes Ilya Dryomov
2017-05-23 16:33 ` [PATCH 1/5] libceph: use kbasename() and kill ceph_file_part() Ilya Dryomov
2017-05-23 17:39 ` Alex Elder
2017-05-23 16:33 ` [PATCH 2/5] libceph: make ceph_msg_data_advance() return void Ilya Dryomov
2017-05-23 17:41 ` Alex Elder
2017-05-23 16:33 ` [PATCH 3/5] libceph: drop version variable from ceph_monmap_decode() Ilya Dryomov
2017-05-23 17:42 ` Alex Elder
2017-05-23 16:33 ` [PATCH 4/5] libceph: validate blob_struct_v in process_one_ticket() Ilya Dryomov
2017-05-23 17:44 ` Alex Elder
2017-05-23 18:40 ` Ilya Dryomov [this message]
2017-05-23 16:33 ` [PATCH 5/5] libceph: fix error handling " Ilya Dryomov
2017-05-23 17:47 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOi1vP9StiPi6ThbC68KUymNgLx1JorQ2OmqLGKtnAQBk+pfNw@mail.gmail.com \
--to=idryomov@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.