From: Ilya Dryomov <idryomov@gmail.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Sage Weil <sage@redhat.com>, Daniel Disseldorp <ddiss@suse.com>,
Jens Axboe <axboe@kernel.dk>,
Ceph Development <ceph-devel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>
Subject: Re: [PATCH 09/15] rbd: count pending object requests in-line
Date: Mon, 3 Feb 2020 18:47:36 +0100 [thread overview]
Message-ID: <CAOi1vP9Z=7XPO3N7jajEG0eJDSUF+xnvn+arfU-waubra9pg-A@mail.gmail.com> (raw)
In-Reply-To: <20200131103739.136098-10-hare@suse.de>
On Fri, Jan 31, 2020 at 11:38 AM Hannes Reinecke <hare@suse.de> wrote:
>
> Instead of having a counter for outstanding object requests
> check the state and count only those which are not in the final
> state.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/block/rbd.c | 41 ++++++++++++++++++++++++++++++-----------
> 1 file changed, 30 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index b708f5ecda07..a6c95b6e9c0c 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -350,7 +350,7 @@ struct rbd_img_request {
> struct mutex object_mutex;
>
> struct mutex state_mutex;
> - struct pending_result pending;
> + int pending_result;
> struct work_struct work;
> int work_result;
> struct kref kref;
> @@ -3602,11 +3602,12 @@ static int rbd_img_exclusive_lock(struct rbd_img_request *img_req)
> return 0;
> }
>
> -static void rbd_img_object_requests(struct rbd_img_request *img_req)
> +static int rbd_img_object_requests(struct rbd_img_request *img_req)
> {
> struct rbd_obj_request *obj_req;
> + int num_pending = 0;
>
> - rbd_assert(!img_req->pending.result && !img_req->pending.num_pending);
> + rbd_assert(!img_req->pending_result);
>
> mutex_lock(&img_req->object_mutex);
> for_each_obj_request(img_req, obj_req) {
> @@ -3617,15 +3618,33 @@ static void rbd_img_object_requests(struct rbd_img_request *img_req)
> __func__, obj_req, obj_req->img_request,
> img_req, result);
> if (result) {
> - img_req->pending.result = result;
> - mutex_unlock(&img_req->object_mutex);
> - return;
> + img_req->pending_result = result;
> + break;
> }
> } else {
> - img_req->pending.num_pending++;
> + num_pending++;
> }
> }
> mutex_unlock(&img_req->object_mutex);
> + return num_pending;
> +}
> +
> +static int rbd_img_object_requests_pending(struct rbd_img_request *img_req)
> +{
> + struct rbd_obj_request *obj_req;
> + int num_pending = 0;
> +
> + mutex_lock(&img_req->object_mutex);
> + for_each_obj_request(img_req, obj_req) {
> + if (obj_req->obj_state > 1)
> + num_pending++;
> + else if (WARN_ON(obj_req->obj_state == 1))
> + num_pending++;
> + else if (WARN_ON(obj_req->pending.num_pending))
> + num_pending++;
> + }
> + mutex_unlock(&img_req->object_mutex);
> + return num_pending;
> }
>
> static bool rbd_img_advance(struct rbd_img_request *img_req, int *result)
> @@ -3658,16 +3677,16 @@ static bool rbd_img_advance(struct rbd_img_request *img_req, int *result)
> __rbd_is_lock_owner(rbd_dev));
>
> img_req->state = RBD_IMG_OBJECT_REQUESTS;
> - rbd_img_object_requests(img_req);
> - if (!img_req->pending.num_pending) {
> - *result = img_req->pending.result;
> + if (!rbd_img_object_requests(img_req)) {
> + *result = img_req->pending_result;
> img_req->state = RBD_IMG_DONE;
> return true;
> }
> return false;
> case RBD_IMG_OBJECT_REQUESTS:
> - if (!pending_result_dec(&img_req->pending, result))
> + if (rbd_img_object_requests_pending(img_req))
> return false;
> + *result = img_req->pending_result;
> img_req->state = RBD_IMG_DONE;
> /* fall through */
> case RBD_IMG_DONE:
This is just to be able to drop img_req->state_mutex in patch 11,
right?
Thanks,
Ilya
next prev parent reply other threads:[~2020-02-03 17:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 10:37 [PATCH 00/15] rbd: switch to blk-mq Hannes Reinecke
2020-01-31 10:37 ` [PATCH 01/15] rbd: lock object request list Hannes Reinecke
2020-02-03 16:38 ` Ilya Dryomov
2020-01-31 10:37 ` [PATCH 02/15] rbd: use READ_ONCE() when checking the mapping size Hannes Reinecke
2020-02-03 16:50 ` Ilya Dryomov
2020-02-04 7:05 ` Hannes Reinecke
2020-01-31 10:37 ` [PATCH 03/15] rbd: reorder rbd_img_advance() Hannes Reinecke
2020-01-31 10:37 ` [PATCH 04/15] rbd: reorder switch statement in rbd_advance_read() Hannes Reinecke
2020-01-31 10:37 ` [PATCH 05/15] rbd: reorder switch statement in rbd_advance_write() Hannes Reinecke
2020-01-31 10:37 ` [PATCH 06/15] rbd: add 'done' state for rbd_obj_advance_copyup() Hannes Reinecke
2020-01-31 10:37 ` [PATCH 07/15] rbd: use callback for image request completion Hannes Reinecke
2020-02-03 17:13 ` Ilya Dryomov
2020-01-31 10:37 ` [PATCH 08/15] rbd: add debugging statements for the state machine Hannes Reinecke
2020-01-31 10:37 ` [PATCH 09/15] rbd: count pending object requests in-line Hannes Reinecke
2020-02-03 17:47 ` Ilya Dryomov [this message]
2020-02-04 6:59 ` Hannes Reinecke
2020-01-31 10:37 ` [PATCH 10/15] rbd: kill 'work_result' Hannes Reinecke
2020-01-31 10:37 ` [PATCH 11/15] rbd: drop state_mutex in __rbd_img_handle_request() Hannes Reinecke
2020-02-03 18:01 ` Ilya Dryomov
2020-01-31 10:37 ` [PATCH 12/15] rbd: kill img_request kref Hannes Reinecke
2020-01-31 10:37 ` [PATCH 13/15] rbd: schedule image_request after preparation Hannes Reinecke
2020-02-03 18:40 ` Ilya Dryomov
2020-01-31 10:37 ` [PATCH 14/15] rbd: embed image request as blk_mq request payload Hannes Reinecke
2020-01-31 10:37 ` [PATCH 15/15] rbd: switch to blk-mq Hannes Reinecke
2020-02-03 8:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOi1vP9Z=7XPO3N7jajEG0eJDSUF+xnvn+arfU-waubra9pg-A@mail.gmail.com' \
--to=idryomov@gmail.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=ddiss@suse.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=sage@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.