All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Dryomov <idryomov@gmail.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: "Yan, Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>,
	Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH -next] libceph: fix return value check in alloc_msg_with_page_vector()
Date: Sat, 30 Jul 2016 16:57:06 +0200	[thread overview]
Message-ID: <CAOi1vP9kgTQ=wAQqCqPCGCoyS_BfrHqvBpmXXuPa-_6tQPG+mA@mail.gmail.com> (raw)
In-Reply-To: <1469839077-3607-1-git-send-email-weiyj.lk@gmail.com>

On Sat, Jul 30, 2016 at 2:37 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> In case of error, the function ceph_alloc_page_vector() returns
> ERR_PTR() and never returns NULL. The NULL test in the return value
> check should be replaced with IS_ERR().
>
> Fixes: 1907920324f1 ('libceph: support for sending notifies')
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
> ---
>  net/ceph/osd_client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

Thanks,

                Ilya

      reply	other threads:[~2016-07-30 14:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-30  0:37 [PATCH -next] libceph: fix return value check in alloc_msg_with_page_vector() Wei Yongjun
2016-07-30 14:57 ` Ilya Dryomov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOi1vP9kgTQ=wAQqCqPCGCoyS_BfrHqvBpmXXuPa-_6tQPG+mA@mail.gmail.com' \
    --to=idryomov@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=sage@redhat.com \
    --cc=weiyj.lk@gmail.com \
    --cc=zyan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.