Re: accessing ath10k calibration data

From: Marty Faltesek <mfaltesek@google.com>
To: "Valo, Kalle" <kvalo@qca.qualcomm.com>
Cc: Adrian Chadd <adrian@freebsd.org>,
	"michal.kazior@tieto.com" <michal.kazior@tieto.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: accessing ath10k calibration data
Date: Tue, 13 Sep 2016 16:49:36 -0400	[thread overview]
Message-ID: <CAOiWkA_Xm3pXGzHEWnCO9JKhahJkKQ6yEVt8DXaHi1cFvoFzew@mail.gmail.com> (raw)
In-Reply-To: <87lgywjcwi.fsf@kamboji.qca.qualcomm.com>

Hey Kalle

OK this does work for me after all. Thanks.

I wrote a patch to cache cal_data only while the core is off. I don't
need it now, but wondering if there is any benefit
to submitting it?

thanks,

Marty

On Tue, Sep 13, 2016 at 6:46 AM, Valo, Kalle <kvalo@qca.qualcomm.com> wrote:
> Marty Faltesek <mfaltesek@google.com> writes:
>
>> On Mon, Sep 12, 2016 at 4:50 AM, Michal Kazior <michal.kazior@tieto.com> wrote:
>>> On 9 September 2016 at 19:42, Marty Faltesek <mfaltesek@google.com> wrote:
>>>> It's blocked by the code below which I tried to ifdef out, but then it
>>>> returns all 0's.
>>>>
>>>> diff --git a/drivers/net/wireless/ath/ath10k/debug.c
>>>> b/drivers/net/wireless/ath/ath10k/debug.c
>>>> index 8b01e3e..bb8b7ec 100644
>>>> --- a/drivers/net/wireless/ath/ath10k/debug.c
>>>> +++ b/drivers/net/wireless/ath/ath10k/debug.c
>>>> @@ -1433,12 +1433,13 @@ static int ath10k_debug_cal_data_open(struct
>>>> inode *inode, struct file *file)
>>>>         int ret;
>>>>
>>>>         mutex_lock(&ar->conf_mutex);
>>>> -
>>>> +#if 0
>>>>         if (ar->state != ATH10K_STATE_ON &&
>>>>             ar->state != ATH10K_STATE_UTF) {
>>>>                 ret = -ENETDOWN;
>>>>                 goto err;
>>>>         }
>>>> +#endif
>>>
>>> This won't work. The driver needs to go through ath10k_start(), i.e.
>>> firmware must be loaded. Cal data is cooked as part of that.
>>>
>>> You could get away with just `ifconfig wlan0 up`. You don't need to
>>> connect or anything.
>>
>> This does not work:
>>
>> hexdump: ./kernel/debug/ieee80211/phy1/ath10k/cal_data: Network is down
>>
>> But it works after starting the AP. Are you sure about what you said?
>
> It should work:
>
> # ip link show wlan0
> 5: wlan0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
>     link/ether 00:03:7f:48:d6:05 brd ff:ff:ff:ff:ff:ff
> # ip link set wlan0 up
> # hexdump /sys/kernel/debug/ieee80211/phy0/ath10k/cal_data
> # ip link set wlan0 down
> # hexdump /sys/kernel/debug/ieee80211/phy0/ath10k/cal_data
> hexdump: /sys/kernel/debug/ieee80211/phy0/ath10k/cal_data: Network is down
> #
>
> What's odd is that I got a file with zero bytes, but no time to
> investigate it now.
>
> --
> Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k