Re: [PATCH v2 1/5] crypto: ccree: correct host regs offset - Gilad Ben-Yossef

From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Simon Horman <horms@verge.net.au>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Ofir Drang <ofir.drang@arm.com>,
	stable@vger.kernel.org,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] crypto: ccree: correct host regs offset
Date: Thu, 31 May 2018 14:49:54 +0300	[thread overview]
Message-ID: <CAOtvUMebK3eM0O0C4bMa+13vej6egVV389AZ=HOnruPbfxZDkg@mail.gmail.com> (raw)
In-Reply-To: <20180529161248.fphjnceozoyxqy7v@verge.net.au>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

On Tue, May 29, 2018 at 7:12 PM, Simon Horman <horms@verge.net.au> wrote:

> On Thu, May 24, 2018 at 03:19:06PM +0100, Gilad Ben-Yossef wrote:
> > The product signature and HW revision register have different offset on
> the
> > older HW revisions.
> > This fixes the problem of the driver failing sanity check on silicon
> > despite working on the FPGA emulation systems.
> >
> > Fixes: 27b3b22dd98c ("crypto: ccree - add support for older HW revs")
>
> Did the above introduce a regression that is fixed by this patch
> or did it add a feature that only works with this patch?
>
>
Sort of in between - the first patch made more devices work but
unreliability (it will sometime work, sometime doesn't).
This one make it work reliably.

> In the case of the latter I would drop the Fixes tag,
> but I don't feel strongly about it.
>

>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
>
> Minor not below not withstanding,
>

> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> Thank you for the review and help :-)

Gilad

[-- Attachment #2: Type: text/html, Size: 3303 bytes --]